Closed
Bug 732755
Opened 8 years ago
Closed 8 years ago
Intermittent test_mozIAsyncLivemarks.js | false == true
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Not set
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: philor, Assigned: mak)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
|
1.07 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=9803884&tree=Mozilla-Inbound Rev3 Fedora 12x64 mozilla-inbound pgo test xpcshell on 2012-03-03 18:54:19 PST for push 9fbe111ef1c3 TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log: ... TEST-INFO | (xpcshell/head.js) | test 2 pending TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | Starting test_removeLivemark_guid_succeeds TEST-INFO | (xpcshell/head.js) | test 2 finished TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 360] true == true TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 361] 234567890ABC == 234567890ABC TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack: JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 462 JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 556 JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_eq :: line 577 JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_true :: line 591 JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js :: <TOP_LEVEL> :: line 366 JS frame :: resource:///components/nsLivemarkService.js :: LS_removeLivemark_ETAT :: line 462
|
Assignee | |
Comment 1•8 years ago
|
||
so the failure is here http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js#366 interesting, I wonder what's failing in the removal.
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
|
|
Assignee | |
Comment 5•8 years ago
|
||
minor timing issue, the guid is written asynchronously and may happen a bit later than we expect.
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
|
||
Comment 8•8 years ago
|
||
Comment on attachment 604637 [details] [diff] [review] patch v1.0 Review of attachment 604637 [details] [diff] [review]: ----------------------------------------------------------------- should convert all that code to use the param data instead of the livemark getters?
Attachment #604637 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
it's just the guid that is a special case, due to the fact we have both sync and async APIs, in future should be less hackish once the old API dies.
|
|
Assignee | |
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b55bf024c09a
Target Milestone: --- → mozilla13
|
|
Assignee | |
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b55bf024c09a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Keywords: intermittent-failure
|
|
||
Updated•7 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•