732755 - Intermittent test_mozIAsyncLivemarks.js | false == true

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9803884&tree=Mozilla-Inbound
Rev3 Fedora 12x64 mozilla-inbound pgo test xpcshell on 2012-03-03 18:54:19 PST for push 9fbe111ef1c3

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
...
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | Starting test_removeLivemark_guid_succeeds

TEST-INFO | (xpcshell/head.js) | test 2 finished

TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 360] true == true

TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 361] 234567890ABC == 234567890ABC

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 462
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 556
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_eq :: line 577
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_true :: line 591
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js :: <TOP_LEVEL> :: line 366
JS frame :: resource:///components/nsLivemarkService.js :: LS_removeLivemark_ETAT :: line 462

Comment 1

[Marco Bonardo [:mak]]

so the failure is here
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js#366
interesting, I wonder what's failing in the removal.

Comment 2

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=9849032&tree=Mozilla-Inbound
Rev3 Fedora 12x64 mozilla-inbound opt test xpcshell on 2012-03-06 04:23:32

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit_ipc/test_traceable_channel_wrap.js | test failed (with xpcshell return code: 0), see following log:
child: TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_traceable_channel.js | failed to get local/remote socket info - See following stack:
child: TEST-UNEXPECTED-FAIL | ../unit/head_channels.js | Failed to load URL: 80004004 - See following stack:
child: TEST-UNEXPECTED-FAIL | ../unit/head_channels.js | Error in onStopRequest: 2147500036 - See following stack:

Comment 3

[Legacy TBPL/Treeherder Robot]

mats
https://tbpl.mozilla.org/php/getParsedLog.php?id=9906808&tree=Try
Rev3 Fedora 12 try opt test xpcshell on 2012-03-08 04:02:34

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:

Comment 4

[Legacy TBPL/Treeherder Robot]

fyan%mozilla.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=9959393&tree=UX
Rev3 WINNT 5.1 ux opt test xpcshell on 2012-03-09 18:13:40

TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\places\tests\unit\test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | c:/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

minor timing issue, the guid is written asynchronously and may happen a bit later than we expect.

Comment 6

[Legacy TBPL/Treeherder Robot]

ryanvm%gmail.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=9977225&tree=Firefox
Rev3 Fedora 12x64 mozilla-central pgo test xpcshell on 2012-03-10 12:54:44

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:

Comment 7

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=9983514&tree=Mozilla-Inbound
Rev3 Fedora 12 mozilla-inbound pgo test xpcshell on 2012-03-10 21:54:39

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 604637 [details] [diff] [review]
patch v1.0

Review of attachment 604637 [details] [diff] [review]:
-----------------------------------------------------------------

should convert all that code to use the param data instead of the livemark getters?

Comment 9

[Marco Bonardo [:mak]]

it's just the guid that is a special case, due to the fact we have both sync and async APIs, in future should be less hackish once the old API dies.

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b55bf024c09a

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b55bf024c09a