Make sure feed sync (bug 705504) is more robust and handles edge cases without UI loss

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Feed Reader
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 13.0

Thunderbird Tracking Flags

(thunderbird12 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
from the issue in bug 705504 comment 48.
(Assignee)

Comment 1

5 years ago
Created attachment 602957 [details] [diff] [review]
patch.


fix blank dialog on bad parms when adding feed from feedUrl (rare case), and add catches to avoid blank dialog on single item error.

this needs to go into Tb12 with bug 705504.
Assignee: nobody → alta88
Attachment #602957 - Flags: review?(dbienvenu)

Updated

5 years ago
Attachment #602957 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 602957 [details] [diff] [review]
patch.

[Approval Request Comment]
Regression caused by (bug #): 705504
User impact if declined: blank subscribe dialog in certain cases.
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): very low.
Attachment #602957 - Flags: approval-comm-aurora?
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/4f7dd383534c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Attachment #602957 - Flags: approval-comm-aurora? → approval-comm-aurora+
Landed on aurora: http://hg.mozilla.org/releases/comm-aurora/rev/8deff9ff0b89
status-thunderbird12: --- → fixed
You need to log in before you can comment on or make changes to this bug.