Closed Bug 732808 Opened 9 years ago Closed 9 years ago

Make Move Bookmarks dialog resizable

Categories

(SeaMonkey :: Bookmarks & History, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.7 wontfix, seamonkey2.8 wontfix, seamonkey2.9 fixed)

RESOLVED FIXED
seamonkey2.10
Tracking Status
seamonkey2.7 --- wontfix
seamonkey2.8 --- wontfix
seamonkey2.9 --- fixed

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Details

Attachments

(1 file)

I just noticed that the Move Bookmarks dialog (actually it's called "Choose Folder"; see BM -> Edit -> Move) is not resizable on Windows. I guess my Linux (Kubuntu) ignores the missing resizable flag.

The attached patch just enables resizing. The dialog already remembers the state and the included folder tree adjusts in both dimensions automatically already.
Attachment #602730 - Flags: review?(neil)
Comment on attachment 602730 [details] [diff] [review]
patch [Checkin: Comments 2 and 4]

Might it be worth a centerscreen, too, to match the new bookmark dialog?

Not important, but I notice that the dialog itself has an hbox too many ;-)
Attachment #602730 - Flags: review?(neil) → review+
Comment on attachment 602730 [details] [diff] [review]
patch [Checkin: Comments 2 and 4]

http://hg.mozilla.org/comm-central/rev/4a91b37fbbfa

(In reply to neil@parkwaycc.co.uk from comment #1)
> Might it be worth a centerscreen, too, to match the new bookmark dialog?

I'm not so sure about that. While the latter is usually opened from a browser window, which may very well be maximized, the Move dialog is solely opened from the Bookmarks Manager, which I guess is usually at a certain position of the screen, possibly even on a different screen (thinking of multi-monitor setups). If the dialog opens relative to the BM (at least initially), I think that's OK. If the dialog is subsequently moved (heh), that will be remembered, so no harm done.

> Not important, but I notice that the dialog itself has an hbox too many ;-)

Well... Feel free to fix that in its own bug. ;-)
Attachment #602730 - Attachment description: patch → patch [Checkin: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.10
Comment on attachment 602730 [details] [diff] [review]
patch [Checkin: Comments 2 and 4]

[Approval Request Comment]
Regression caused by (bug #): Bug 498596
User impact if declined: Dialog not resizable on Windows
Testing completed (on m-c, etc.): Baked on trunk
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #602730 - Flags: approval-comm-aurora?
Attachment #602730 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 602730 [details] [diff] [review]
patch [Checkin: Comments 2 and 4]

http://hg.mozilla.org/releases/comm-aurora/rev/c821822ca24e
Attachment #602730 - Attachment description: patch [Checkin: Comment 2] → patch [Checkin: Comments 2 and 4]
You need to log in before you can comment on or make changes to this bug.