Add URLbar formatting preference entry

RESOLVED FIXED

Status

SeaMonkey
Location Bar
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Some of our more conservative users will want to be able to turn it off.
(Assignee)

Comment 1

6 years ago
Created attachment 602735 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #602735 - Flags: review?(jh)
Comment on attachment 602735 [details] [diff] [review]
Proposed patch

Review of attachment 602735 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with my suggestion, otherwise please discuss or provide a new patch.

Please file a Help follow-up bug and feel free to also provide a patch there. :-)

::: suite/locales/en-US/chrome/common/pref/pref-locationbar.dtd
@@ +23,5 @@
>  <!ENTITY autoCompleteMatchWords                "Only on word boundaries">
>  <!ENTITY autoCompleteMatchStart                "Only at the beginning of the location or title">
>  
> +<!ENTITY formatting.label                      "Formatting">
> +<!ENTITY domainFormatting.label                "Display the effective domain for websites and FTP servers">

Hmm, "Display" suggests that if you do not have this option enabled, the domain will *not* be displayed. That's surely not what we want to suggest, do we? ;-)

Maybe "Highlight"? [You cannot use "H" as accesskey then because it's bound to Help, but "d" for "domain".]
Attachment #602735 - Flags: review?(jh) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 602744 [details] [diff] [review]
Addressed review comments

I noticed an obsolete note (fixed2.1) so I removed it while it was there.
Attachment #602735 - Attachment is obsolete: true
Attachment #602744 - Flags: review?(jh)
Attachment #602744 - Flags: review?(jh) → review+
(Assignee)

Comment 4

6 years ago
Pushed changeset c1fa6cb7574e to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.