Last Comment Bug 732816 - Add URLbar formatting preference entry
: Add URLbar formatting preference entry
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Location Bar (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: neil@parkwaycc.co.uk
:
Mentors:
Depends on: 689139
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-04 09:35 PST by neil@parkwaycc.co.uk
Modified: 2012-03-07 12:48 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (3.54 KB, patch)
2012-03-04 09:37 PST, neil@parkwaycc.co.uk
jh: review+
Details | Diff | Review
Addressed review comments (5.80 KB, patch)
2012-03-04 10:55 PST, neil@parkwaycc.co.uk
jh: review+
Details | Diff | Review

Description neil@parkwaycc.co.uk 2012-03-04 09:35:00 PST
Some of our more conservative users will want to be able to turn it off.
Comment 1 neil@parkwaycc.co.uk 2012-03-04 09:37:45 PST
Created attachment 602735 [details] [diff] [review]
Proposed patch
Comment 2 Jens Hatlak (:InvisibleSmiley) 2012-03-04 09:52:36 PST
Comment on attachment 602735 [details] [diff] [review]
Proposed patch

Review of attachment 602735 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with my suggestion, otherwise please discuss or provide a new patch.

Please file a Help follow-up bug and feel free to also provide a patch there. :-)

::: suite/locales/en-US/chrome/common/pref/pref-locationbar.dtd
@@ +23,5 @@
>  <!ENTITY autoCompleteMatchWords                "Only on word boundaries">
>  <!ENTITY autoCompleteMatchStart                "Only at the beginning of the location or title">
>  
> +<!ENTITY formatting.label                      "Formatting">
> +<!ENTITY domainFormatting.label                "Display the effective domain for websites and FTP servers">

Hmm, "Display" suggests that if you do not have this option enabled, the domain will *not* be displayed. That's surely not what we want to suggest, do we? ;-)

Maybe "Highlight"? [You cannot use "H" as accesskey then because it's bound to Help, but "d" for "domain".]
Comment 3 neil@parkwaycc.co.uk 2012-03-04 10:55:46 PST
Created attachment 602744 [details] [diff] [review]
Addressed review comments

I noticed an obsolete note (fixed2.1) so I removed it while it was there.
Comment 4 neil@parkwaycc.co.uk 2012-03-07 12:48:52 PST
Pushed changeset c1fa6cb7574e to comm-central.

Note You need to log in before you can comment on or make changes to this bug.