732836 - "ASSERTION: Unknown unit type" with multiple <svg:use>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Unknown unit type: 'Not Reached', file content/svg/content/src/nsSVGLength2.cpp, line 270

You might have to hover over the testcase to see the assertion failure.

Comment 1

[Jesse Ruderman]

Attachment: stack trace+

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Daniel Holbert [:dholbert]]

Does the crashtest reproduce the bug in the crashtest harness?  (without the mouse hovering over the crashtest?)

Comment 4

[Robert Longson [:longsonr]]

Attachment: updated

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Does the crashtest reproduce the bug in the crashtest harness?  (without the
> mouse hovering over the crashtest?)

Erm no, but this version does ;-)

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 602956 [details] [diff] [review]
updated

Cool. :) Looks good, thanks!

Comment 6

[Robert Longson [:longsonr]]

Attachment: fix the real issue

I had another look at this and although the first patch does fix the testcase, there is an underlying issue in copying values when a use attribute goes away. This patch reverts part of bug 730658 to fix that. 

This patch on its own also fixes the testcase not to assert.

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 603318 [details] [diff] [review]
fix the real issue

Cool. (Make sure to grab the crashtest from the other patch, too.)

Comment 8

[Robert Longson [:longsonr]]

I plan to land both patches.

Comment 9

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/e984475c1fdb

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e984475c1fdb