Closed Bug 732836 Opened 8 years ago Closed 8 years ago

"ASSERTION: Unknown unit type" with multiple <svg:use>

Categories

(Core :: SVG, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: jruderman, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(4 files, 1 obsolete file)

Attached image testcase
###!!! ASSERTION: Unknown unit type: 'Not Reached', file content/svg/content/src/nsSVGLength2.cpp, line 270

You might have to hover over the testcase to see the assertion failure.
Attached file stack trace+
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #602947 - Flags: review?(dholbert)
Does the crashtest reproduce the bug in the crashtest harness?  (without the mouse hovering over the crashtest?)
Attached patch updatedSplinter Review
(In reply to Daniel Holbert [:dholbert] from comment #3)
> Does the crashtest reproduce the bug in the crashtest harness?  (without the
> mouse hovering over the crashtest?)

Erm no, but this version does ;-)
Attachment #602947 - Attachment is obsolete: true
Attachment #602956 - Flags: review?(dholbert)
Attachment #602947 - Flags: review?(dholbert)
Attachment #602956 - Attachment is patch: true
Comment on attachment 602956 [details] [diff] [review]
updated

Cool. :) Looks good, thanks!
Attachment #602956 - Flags: review?(dholbert) → review+
I had another look at this and although the first patch does fix the testcase, there is an underlying issue in copying values when a use attribute goes away. This patch reverts part of bug 730658 to fix that. 

This patch on its own also fixes the testcase not to assert.
Attachment #603318 - Flags: review?(dholbert)
Comment on attachment 603318 [details] [diff] [review]
fix the real issue

Cool. (Make sure to grab the crashtest from the other patch, too.)
Attachment #603318 - Flags: review?(dholbert) → review+
I plan to land both patches.
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/e984475c1fdb
Flags: in-testsuite+
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/e984475c1fdb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.