Closed
Bug 732877
Opened 13 years ago
Closed 13 years ago
GCC 4.6 build warning: nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this build warning:
{
nsGlobalWindow.cpp: In member function ‘virtual nsresult nsGlobalWindow::SetNewDocument(nsIDocument*, nsISupports*, bool)’:
nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]
}
This chunk removed the only uses of |oldPrincipal| a few months ago:
http://hg.mozilla.org/mozilla-central/diff/11d6f47eea30/dom/base/nsGlobalWindow.cpp#l1.122
Looks like we don't need this variable anymore.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #602802 -
Flags: review?(jst)
|
||
Updated•13 years ago
|
Attachment #602802 -
Flags: review?(jst) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•