Closed Bug 732877 Opened 8 years ago Closed 8 years ago

GCC 4.6 build warning: nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filing bug on this build warning:
{
nsGlobalWindow.cpp: In member function ‘virtual nsresult nsGlobalWindow::SetNewDocument(nsIDocument*, nsISupports*, bool)’:
nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]
}

This chunk removed the only uses of |oldPrincipal| a few months ago:
http://hg.mozilla.org/mozilla-central/diff/11d6f47eea30/dom/base/nsGlobalWindow.cpp#l1.122

Looks like we don't need this variable anymore.
Attached patch fix v1Splinter Review
Attachment #602802 - Flags: review?(jst)
Attachment #602802 - Flags: review?(jst) → review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/060cc6982c6d
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/060cc6982c6d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.