GCC 4.6 build warning: nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Filing bug on this build warning:
{
nsGlobalWindow.cpp: In member function ‘virtual nsresult nsGlobalWindow::SetNewDocument(nsIDocument*, nsISupports*, bool)’:
nsGlobalWindow.cpp:1937:17: warning: variable ‘oldPrincipal’ set but not used [-Wunused-but-set-variable]
}

This chunk removed the only uses of |oldPrincipal| a few months ago:
http://hg.mozilla.org/mozilla-central/diff/11d6f47eea30/dom/base/nsGlobalWindow.cpp#l1.122

Looks like we don't need this variable anymore.
(Assignee)

Comment 1

6 years ago
Created attachment 602802 [details] [diff] [review]
fix v1
Attachment #602802 - Flags: review?(jst)

Updated

6 years ago
Attachment #602802 - Flags: review?(jst) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/060cc6982c6d
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/060cc6982c6d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.