73288 - Host/Domain indicator not properly updated in cookie manager

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Stephen P. Morse]

1. Collect at least one host cookie and one domain cookie.  Visiting 
home.netscape.com will accomplish that.

2. Open cookie manager dialog (tasks->privacy->cookies->view cookies

3. Click on the host cookie.  The heading on the third field of cookie 
information says host.  That is good.

4. Click on the domain cookie.  The heading on the third field of the cookie 
still says host.  That is bad.

Comment 1

[Stephen P. Morse]

Problem is an overzelous application of the "value" -> "label" change that was 
done when the xul syntax changed.  Specifically the following lines appear 
in CookieViewer.js:

  var dtypecell = document.getElementById("ifl_domaintype");
  dtypecell.setAttribute("label", cookies[idx].domaintype+":");

Unfortunately ifl_domaintype is a textbox (used to be a textfield) so its 
attribute should not have been changed to "label".  Restoring it back to "value" 
(which is what it used to be) clears this up.

Will not be attaching a patch here because the cookie module (including this 
file) is currently undergoing a major reorg (see bug 46783) and this fix will 
simply be included as part of the patch for that bug.  When that checkin occurs 
I will be able to close out this bug report as fixed.

Comment 2

[Stephen P. Morse]

Fixed as part of the checkin for bug 46783 that just occured.

Comment 3

[Tom Everingham]

verified