Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IonMonkey: Rectifier frames are wonky on ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 602878 [details] [diff] [review]
/home/mrosenberg/patches/rectifier_frame-r0.patch

I'm not too sure why there are two different rectifier frame types that report different sizes, but on ARM they both seem to be the same size, 16 bytes.
this patch makes a crash go away, that is about all I can say definitively.
Attachment #602878 - Flags: review?(dvander)
Comment on attachment 602878 [details] [diff] [review]
/home/mrosenberg/patches/rectifier_frame-r0.patch

Review of attachment 602878 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/IonFrames-arm.h
@@ +135,5 @@
>    public:
>      static inline size_t Size() {
>          // Include an extra word for the dead callee token.
> +        // I'm pretty sure we don't actually need to do that, since that seems to
> +        // be causing a crash.

Err... this comment has multiple personalities :)

r=me w/ both comments removed and a new one added explaining why it differs from x86. Taking a quick look, it might be that sizeof(IonExitFrame) == sizeof(IonRectifierFrame), which isn't true on x86.
Attachment #602878 - Flags: review?(dvander) → review+
(Reporter)

Comment 2

5 years ago
landed: http://hg.mozilla.org/projects/ionmonkey/rev/4c4cce686988
(Reporter)

Comment 3

5 years ago
clicked too soon
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.