732949 - IonMonkey: Rectifier frames are wonky on ARM

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: /home/mrosenberg/patches/rectifier_frame-r0.patch

I'm not too sure why there are two different rectifier frame types that report different sizes, but on ARM they both seem to be the same size, 16 bytes.
this patch makes a crash go away, that is about all I can say definitively.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 602878 [details] [diff] [review]
/home/mrosenberg/patches/rectifier_frame-r0.patch

Review of attachment 602878 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/IonFrames-arm.h
@@ +135,5 @@
>    public:
>      static inline size_t Size() {
>          // Include an extra word for the dead callee token.
> +        // I'm pretty sure we don't actually need to do that, since that seems to
> +        // be causing a crash.

Err... this comment has multiple personalities :)

r=me w/ both comments removed and a new one added explaining why it differs from x86. Taking a quick look, it might be that sizeof(IonExitFrame) == sizeof(IonRectifierFrame), which isn't true on x86.

Comment 2

[Marty Rosenberg [:mjrosenb]]

landed: http://hg.mozilla.org/projects/ionmonkey/rev/4c4cce686988

Comment 3

[Marty Rosenberg [:mjrosenb]]

clicked too soon