Closed Bug 732960 Opened 8 years ago Closed 8 years ago

Updates for the PSL

Categories

(Core :: Networking: Domain Lists, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: weppos, Unassigned)

Details

Attachments

(7 files)

Please find attached 7 patches for the PSL.

I committed the changes separately so that you can easily review and merge them selectively.
Taking advantage that a HG commit is also a unified diff, I generated the patches from commits against the master branch. The commit message contains an explanation of each single patch.
Simone: can you give us more information as to your information sources for these changes?

I'm not sure we want to take the trailing-space-removal; we can't guarantee not reintroducing them in the future, so perhaps we need to keep at least one so people don't write parsers which break when they are present.

Gerv
Status: UNCONFIRMED → NEW
Ever confirmed: true
As far as I remember (as you know the patches were created in December) I should have listed the information source as a comment above each TLD section.

For example, the changes suggested in the patch 1 originates from http://www.nic.sh/registrar.html (line 3).
Whenever available, I researched the information at the original TLD maintainer website or WHOIS page. I also used Wikipedia as a secondary source, but normally just to confirm the original one.

When I was not sure of the information for whatever reason, I also run a allinurl: query on Google to make sure the results confirmed the available documentation.

> I'm not sure we want to take the trailing-space-removal; we can't guarantee not reintroducing them in the future, so perhaps we need to keep at least one so people don't write parsers which break when they are present.

It's pretty easy to strip leading spaces when parsing the list, a space shouldn't be a big deal. However I thought it was a good idea to remove it since in this case it was an exception compared to the rest of the list.
Any update on this issue?
Comment on attachment 602886 [details] [diff] [review]
Update PSL for .SH

You've added .net.sh twice. :-)

Gerv
Attachment #602886 - Flags: review-
Comment on attachment 602892 [details] [diff] [review]
Remove trailing spaces from PSL that may cause parsing issues.

r-, because we don't want people to rely on this being the case always.

Gerv
Attachment #602892 - Flags: review-
(In reply to Gervase Markham [:gerv] from comment #11)
> Comment on attachment 602892 [details] [diff] [review]
> Remove trailing spaces from PSL that may cause parsing issues.
> 
> r-, because we don't want people to rely on this being the case always.
> 
> Gerv

Given that I'm ok with the fact people don't need to rely on this, what's the point of keeping the space here now that we discovered it? :D
(In reply to Gervase Markham [:gerv] from comment #13)
> Simone: when you update the .sh patch, can you file a new bug for it,
> please, so this one can be closed when these get merged to mozilla-central?
> Thanks :-)
> 
> Gerv

I'll do.
You need to log in before you can comment on or make changes to this bug.