Closed Bug 732963 Opened 8 years ago Closed 8 years ago

xulrunner shouldn't use pretty name for checksums files

Categories

(Firefox Build System :: General, defect, P2)

defect

Tracking

(firefox-esr10 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr10 --- fixed

People

(Reporter: rail, Assigned: rail)

Details

(Whiteboard: [Leave open after merge])

Attachments

(1 file)

We upload xulrunner deliverables for all platforms in one directory. Checksums files use pretty name schema and doesn't contain platform name in the file name. Checksums file name should have the same basename as PKG_BASENAME.
Attachment #602897 - Flags: review?(khuey)
Whiteboard: [Leave open after merge]
Comment on attachment 602897 [details] [diff] [review]
xulrunner checksums, no pretty names

This patch can be reproduced only in release builds and doesn't affect any CI builds. Worked fine in m-c and staging release builds.

Regression caused by (bug #): the current bug
Testing completed (on m-c, etc.): tested in dev environment by running staging releases 
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none
Attachment #602897 - Flags: approval-mozilla-beta?
Comment on attachment 602897 [details] [diff] [review]
xulrunner checksums, no pretty names

[Triage comment]
Approved low-risk, non-CI affecting, dev tested.
Attachment #602897 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Worked fine in 12.0b1 build2
Comment on attachment 602897 [details] [diff] [review]
xulrunner checksums, no pretty names

I would like to land this patch on m-r and esr10 branches. 12.0b1 release passed without any problems. The risk is very low since patch contains only cosmetic but needed by release automation changes.
Attachment #602897 - Flags: approval-mozilla-release?
Attachment #602897 - Flags: approval-mozilla-esr10?
Comment on attachment 602897 [details] [diff] [review]
xulrunner checksums, no pretty names

[Triage Comment]
sounds good, low risk, please go ahead and land.
Attachment #602897 - Flags: approval-mozilla-release?
Attachment #602897 - Flags: approval-mozilla-release+
Attachment #602897 - Flags: approval-mozilla-esr10?
Attachment #602897 - Flags: approval-mozilla-esr10+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.