Closed
Bug 732963
Opened 12 years ago
Closed 12 years ago
xulrunner shouldn't use pretty name for checksums files
Categories
(Firefox Build System :: General, defect, P2)
Firefox Build System
General
Tracking
(firefox-esr10 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr10 | --- | fixed |
People
(Reporter: rail, Assigned: rail)
Details
(Whiteboard: [Leave open after merge])
Attachments
(1 file)
1.46 KB,
patch
|
khuey
:
review+
lsblakk
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
We upload xulrunner deliverables for all platforms in one directory. Checksums files use pretty name schema and doesn't contain platform name in the file name. Checksums file name should have the same basename as PKG_BASENAME.
Attachment #602897 -
Flags: review?(khuey)
Attachment #602897 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names http://hg.mozilla.org/integration/mozilla-inbound/rev/5774e4736140
Attachment #602897 -
Flags: checkin+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [Leave open after merge]
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5774e4736140
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names This patch can be reproduced only in release builds and doesn't affect any CI builds. Worked fine in m-c and staging release builds. Regression caused by (bug #): the current bug Testing completed (on m-c, etc.): tested in dev environment by running staging releases Risk to taking this patch (and alternatives if risky): very low String changes made by this patch: none
Attachment #602897 -
Flags: approval-mozilla-beta?
Comment 4•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names [Triage comment] Approved low-risk, non-CI affecting, dev tested.
Attachment #602897 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names http://hg.mozilla.org/releases/mozilla-beta/rev/0457b542fba7
Assignee | ||
Comment 6•12 years ago
|
||
Worked fine in 12.0b1 build2
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names I would like to land this patch on m-r and esr10 branches. 12.0b1 release passed without any problems. The risk is very low since patch contains only cosmetic but needed by release automation changes.
Attachment #602897 -
Flags: approval-mozilla-release?
Attachment #602897 -
Flags: approval-mozilla-esr10?
Comment 8•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names [Triage Comment] sounds good, low risk, please go ahead and land.
Attachment #602897 -
Flags: approval-mozilla-release?
Attachment #602897 -
Flags: approval-mozilla-release+
Attachment #602897 -
Flags: approval-mozilla-esr10?
Attachment #602897 -
Flags: approval-mozilla-esr10+
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 602897 [details] [diff] [review] xulrunner checksums, no pretty names http://hg.mozilla.org/releases/mozilla-release/rev/3990fcb06900 http://hg.mozilla.org/releases/mozilla-esr10/rev/2b9b6e9e8af7
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
status-firefox-esr10:
--- → fixed
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•