Closed Bug 732970 Opened 12 years ago Closed 12 years ago

fix thinko in persistent telemetry merge

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

We have:

  getHistograms: function getHistograms() {
    let hls = Telemetry.histogramSnapshots;

but later on:

    if (havePreviousSession) {
      payloadObj.histograms = this.getHistograms(this._prevSession.snapshots);
    }
    else {
      payloadObj.simpleMeasurements = getSimpleMeasurements();
      payloadObj.histograms = this.getHistograms(Telemetry.histogramSnapshots);

which is clearly not winning.  Earlier versions of the persistent telemetry stuff did the right thing, so this is the result of some bad merge-fu.
Attached patch patchSplinter Review
Straightforward patch.  I love JavaScript.
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
Attachment #602934 - Flags: review?(taras.mozilla)
Whiteboard: [autoland-try:-b do -p all -u xpcshell -t none]
Whiteboard: [autoland-try:-b do -p all -u xpcshell -t none] → [autoland-in-queue]
Autoland Patchset:
	Patches: 602934
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d089d32dd6b4
Try run started, revision d089d32dd6b4. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d089d32dd6b4
Try run for d089d32dd6b4 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d089d32dd6b4
Results (out of 28 total builds):
    success: 23
    warnings: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d089d32dd6b4
Whiteboard: [autoland-in-queue]
Attachment #602934 - Flags: review?(taras.mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/54a7b61b9535
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.