Closed
Bug 733012
Opened 14 years ago
Closed 14 years ago
Firefox 10.0.3esr#1 update channel defaults to nightly-esr10 instead of esr
Categories
(Release Engineering :: Release Requests, defect)
Release Engineering
Release Requests
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: u279076, Assigned: bhearsum)
References
Details
Attachments
(3 files)
|
16.13 KB,
image/png
|
Details | |
|
2.02 KB,
patch
|
mozilla
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
2.07 KB,
patch
|
mozilla
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Screenshot: incorrect update channel
Firefox 10.0.3esr build 1 has it's default update channel set to "nightly-esr10" instead of "esr" (see attached screenshot).
|
||
Comment 2•14 years ago
|
||
Regression from one of the patches on bug 725852?
|
Assignee | |
Comment 3•14 years ago
|
||
Yup, this is my fault. I've got a patch.
Assignee: nobody → bhearsum
|
||
Comment 4•14 years ago
|
||
For Mobile (XUL), MOZ_UPDATE_CHANNEL got set with the string "esr" -- app.update.channel with the value 'esr'. Looks like mobile is unaffected (alongside updates handled by the market).
|
|
Assignee | |
Comment 5•14 years ago
|
||
This drops all usage of update_channel in release.py in favour of an intelligent default and an optional override in the release config. Because we have branches that have nightlies AND releases (1.9.2 and esr), relying on config.py is too confusing IMO.
Attachment #602964 -
Flags: review?(aki)
|
|
Assignee | |
Comment 6•14 years ago
|
||
With this patch applied, here's what the release configs look like w.r.t. releaseChannel:
grep releaseChannel *
release-firefox-mozilla-beta.py:releaseConfig['releaseChannel'] = 'beta'
release-firefox-mozilla-esr10.py:releaseConfig['releaseChannel'] = 'esr'
staging_release-firefox-mozilla-beta.py:releaseConfig['releaseChannel'] = 'beta'
staging_release-firefox-mozilla-esr10.py:releaseConfig['releaseChannel'] = 'esr'
Attachment #602965 -
Flags: review?(aki)
|
||
Updated•14 years ago
|
Attachment #602964 -
Flags: review?(aki) → review+
|
|
||
Updated•14 years ago
|
Attachment #602965 -
Flags: review?(aki) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #602964 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #602965 -
Flags: checked-in+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Will be fixed for when we rebuild.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
|
|
Assignee | |
Comment 8•14 years ago
|
||
I think you re-opened this by accident :)
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•14 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #7)
> Will be fixed for when we rebuild.
grrr... bugzilla cache error. Re-RESOLVED FIXED.
|
||
Comment 11•14 years ago
|
||
Setting resolution to Verified Fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.3) Gecko/20100101 Firefox/10.0.3
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20100101 Firefox/10.0.3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.3) Gecko/20100101 Firefox/10.0.3
The update channel is "esr".
Status: RESOLVED → VERIFIED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•