733087 - Support DT_FLAGS a little bit

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This ignores the DF_SYMBOLIC flag.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Support DT_FLAGS a little bit

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 603002 [details] [diff] [review]
Support DT_FLAGS a little bit

Out of curiosity, what toolchain do you use that creates a lib with DT_FLAGS instead of DT_SYMBOLIC?

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 603002 [details] [diff] [review]
Support DT_FLAGS a little bit

Review of attachment 603002 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/CustomElf.cpp
@@ +549,5 @@
>          break;
> +      case DT_FLAGS:
> +        {
> +           Word flags = dyn->d_un.d_val;
> +           flags &= ~DF_SYMBOLIC; /* we can treat this like having a DT_SYMBOLIC tag */

I guess this is larger than 80 characters. Please wrap.

@@ +551,5 @@
> +        {
> +           Word flags = dyn->d_un.d_val;
> +           flags &= ~DF_SYMBOLIC; /* we can treat this like having a DT_SYMBOLIC tag */
> +           log("%s: Warning: unhandled flags #%" PRIxAddr" not handled",
> +               GetPath(), flags);

I missed that originally: please do not display when flags == DT_SYMBOLIC.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Support DT_FLAGS a little bit v2

A better version. I saw this when linking apitrace with gold.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 603011 [details] [diff] [review]
Support DT_FLAGS a little bit v2

Review of attachment 603011 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land it straight away.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00b9b543a781

Comment 7

[Mike Hommey [:glandium]]

Fixup:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc3e20ff0e0

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/00b9b543a781
https://hg.mozilla.org/mozilla-central/rev/4bc3e20ff0e0