Closed
Bug 733087
Opened 12 years ago
Closed 12 years ago
Support DT_FLAGS a little bit
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
854 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This ignores the DF_SYMBOLIC flag.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #603002 -
Flags: review?(mh+mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 603002 [details] [diff] [review] Support DT_FLAGS a little bit Out of curiosity, what toolchain do you use that creates a lib with DT_FLAGS instead of DT_SYMBOLIC?
Attachment #603002 -
Flags: review?(mh+mozilla) → review+
Comment 3•12 years ago
|
||
Comment on attachment 603002 [details] [diff] [review] Support DT_FLAGS a little bit Review of attachment 603002 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/linker/CustomElf.cpp @@ +549,5 @@ > break; > + case DT_FLAGS: > + { > + Word flags = dyn->d_un.d_val; > + flags &= ~DF_SYMBOLIC; /* we can treat this like having a DT_SYMBOLIC tag */ I guess this is larger than 80 characters. Please wrap. @@ +551,5 @@ > + { > + Word flags = dyn->d_un.d_val; > + flags &= ~DF_SYMBOLIC; /* we can treat this like having a DT_SYMBOLIC tag */ > + log("%s: Warning: unhandled flags #%" PRIxAddr" not handled", > + GetPath(), flags); I missed that originally: please do not display when flags == DT_SYMBOLIC.
Attachment #603002 -
Flags: review+ → review-
Reporter | ||
Comment 4•12 years ago
|
||
A better version. I saw this when linking apitrace with gold.
Attachment #603002 -
Attachment is obsolete: true
Attachment #603011 -
Flags: review?(mh+mozilla)
Comment 5•12 years ago
|
||
Comment on attachment 603011 [details] [diff] [review] Support DT_FLAGS a little bit v2 Review of attachment 603011 [details] [diff] [review]: ----------------------------------------------------------------- I'll land it straight away.
Attachment #603011 -
Flags: review?(mh+mozilla) → review+
Comment 7•12 years ago
|
||
Fixup: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc3e20ff0e0
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00b9b543a781 https://hg.mozilla.org/mozilla-central/rev/4bc3e20ff0e0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•