733233 - Create getTabForWindow helper function

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: patch

When working on bug 711624, I wanted a getTabForWindow function, but I noticed we didn't have one. Then I noticed that in a bunch of places we are calling getBrowserForWindow followed by getTabForBrowser to achieve the same effect. However, if you look at the implementation of these methods, that feels really silly, since getTabForBrowser is basically just doing exactly what getBrowserForWindow just did. I know we probably don't ever have enough tabs for this to really affect performance, but this seems simpler.

My one concern is that we have really crappy test coverage, so we'll have to look at this patch closely to make sure I didn't make any mistakes. I tried to be really careful to make sure the browsers from the getBrowserForWindow calls weren't being used for anything else.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 603121 [details] [diff] [review]
patch

Review of attachment 603121 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me. Minor refactoring for something we're reusing all over the place.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a21a8c92b848

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a21a8c92b848