733490 - Run v8 on try

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P4)

Description

[Justin Lebar (not reading bugmail)]

We run v8 on mozilla-inbound, but there's no way to force it on try.

This means that if I regress v8 on inbound (as I did in bug 729940), there's no way for me to test whether I fixed it without pushing to m-i.  (In bug 729940, I also regressed Dromaeo jslib, but only on Windows, while the v8 regression was on Linux as well, so finding the regression using Dromaeo will be much slower than using v8.)

If there's a good reason not to run v8 on try, I wonder why we're running it on m-i?

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Why are we running this on m-i and not m-c?

Comment 2

[Phil Ringnalda (:philor)]

Because we ran it only on the TraceMonkey tree, because js hackers wanted to know the effect of their patches on it but didn't feel the need to have it run against every single non-js/src/ push, and then mozilla-inbound became the new TraceMonkey.

Comment 3

[Justin Lebar (not reading bugmail)]

(In reply to Phil Ringnalda (:philor) from comment #2)
> Because we ran it only on the TraceMonkey tree, because js hackers wanted to
> know the effect of their patches on it but didn't feel the need to have it
> run against every single non-js/src/ push, and then mozilla-inbound became
> the new TraceMonkey.

And the missing piece is that JS hackers used TM like try (was my understanding).  But we don't use m-i like try.

Comment 4

[Armen [:armenzg]]

Do we want this enabled everywhere? or just m-i and try?

Comment 5

[Justin Lebar (not reading bugmail)]

> But we don't use m-i like try.

Or at least, that's not sanctioned... :)

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #4)
> Do we want this enabled everywhere? or just m-i and try?

I kind of feel like we should run it everywhere, if we think it's a good benchmark, or nowhere, if we don't.  But so long as it's on try, I'm happy.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

currently now we have v8 (version 7) in the dromaeojs suite.  This just landed today and it runs on all platforms.  I am looking to disable the old v8 for trunk based branches in bug 781290.

Comment 7

[Phil Ringnalda (:philor)]

Fixed by bug 781290, long ago.