733495 - Monitor ullAvailPageFile on Windows and fire a memory-pressure event when it gets low

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

MEMORYSTATUSEX.ullAvailPageFile tells us how much space is available in physical memory plus the page file.

When this gets to 0, Windows will not let us map any more memory.  So we should raise a low-memory event before we get here.

Comment 1

[Justin Lebar (not reading bugmail)]

See also bug 720444, where we added ullAvailPageFile to crash reports.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: WIP v1

Comment 3

[Justin Lebar (not reading bugmail)]

I need to add a line to telemetryping.js to send this memory reporter.

Comment 4

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 5

[Mozilla RelEng Bot]

Try run for 5377fc9154a5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=5377fc9154a5
Results (out of 50 total builds):
    success: 40
    warnings: 8
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-5377fc9154a5
 Timed out after 06 hours without completing.

Comment 6

[Justin Lebar (not reading bugmail)]

Landed on m-i

  https://hg.mozilla.org/integration/mozilla-inbound/rev/b2ac02d89f41

but this had the wrong bug number (gah), so backed out and re-landed

  https://hg.mozilla.org/integration/mozilla-inbound/rev/37441c99ccf1
  https://hg.mozilla.org/integration/mozilla-inbound/rev/cad7f1ab3594

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/cad7f1ab3594

Comment 8

[Daniel C]

I think this might be covered elsewhere, but I can't find it. Why is the checking for low physical, commit and virtual memory Windows-only?

Comment 9

[Justin Lebar (not reading bugmail)]

(In reply to Daniel Cater from comment #8)
> I think this might be covered elsewhere, but I can't find it. Why is the
> checking for low physical, commit and virtual memory Windows-only?

Because it's hard(er) to do elsewhere, and because it's not a clear win on Windows, so we wanted to do it there before wasting our time elsewhere.

Also, Windows machines are much more likely to be running a 32-bit Firefox than Mac or Linux.

https://bugzilla.mozilla.org/show_bug.cgi?id=664291