Monitor ullAvailPageFile on Windows and fire a memory-pressure event when it gets low

RESOLVED FIXED in mozilla13

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla13
x86_64
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P1])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
MEMORYSTATUSEX.ullAvailPageFile tells us how much space is available in physical memory plus the page file.

When this gets to 0, Windows will not let us map any more memory.  So we should raise a low-memory event before we get here.
(Assignee)

Comment 1

6 years ago
See also bug 720444, where we added ullAvailPageFile to crash reports.
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
Whiteboard: [MemShrink]
(Assignee)

Updated

6 years ago
OS: Linux → Windows XP
(Assignee)

Updated

6 years ago
Summary: Monitor ullAvailPageFile on Windows and fire a low-memory event when it gets low → Monitor ullAvailPageFile on Windows and fire a memory-pressure event when it gets low
(Assignee)

Comment 2

6 years ago
Created attachment 603434 [details] [diff] [review]
WIP v1
Whiteboard: [MemShrink] → [MemShrink:P1]
(Assignee)

Comment 3

6 years ago
I need to add a line to telemetryping.js to send this memory reporter.
(Assignee)

Comment 4

6 years ago
Created attachment 603583 [details] [diff] [review]
Patch v1
Attachment #603583 - Flags: review?(benjamin)
(Assignee)

Updated

6 years ago
Attachment #603434 - Attachment is obsolete: true

Comment 5

6 years ago
Try run for 5377fc9154a5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=5377fc9154a5
Results (out of 50 total builds):
    success: 40
    warnings: 8
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jlebar@mozilla.com-5377fc9154a5
 Timed out after 06 hours without completing.
Attachment #603583 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

6 years ago
Landed on m-i

  https://hg.mozilla.org/integration/mozilla-inbound/rev/b2ac02d89f41

but this had the wrong bug number (gah), so backed out and re-landed

  https://hg.mozilla.org/integration/mozilla-inbound/rev/37441c99ccf1
  https://hg.mozilla.org/integration/mozilla-inbound/rev/cad7f1ab3594
https://hg.mozilla.org/mozilla-central/rev/cad7f1ab3594
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

Comment 8

6 years ago
I think this might be covered elsewhere, but I can't find it. Why is the checking for low physical, commit and virtual memory Windows-only?
(Assignee)

Comment 9

6 years ago
(In reply to Daniel Cater from comment #8)
> I think this might be covered elsewhere, but I can't find it. Why is the
> checking for low physical, commit and virtual memory Windows-only?

Because it's hard(er) to do elsewhere, and because it's not a clear win on Windows, so we wanted to do it there before wasting our time elsewhere.

Also, Windows machines are much more likely to be running a 32-bit Firefox than Mac or Linux.

https://bugzilla.mozilla.org/show_bug.cgi?id=664291
You need to log in before you can comment on or make changes to this bug.