733522 - Don't show Telemetry opt-out notification for users who have already opted in or out

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Bug 725407 added a notification for Aurora/Nightly users that Telemetry is opt-out on these channels. The notification will be shown to all users. However, if a user has already opted in or out of Telemetry we will continue to respect their selection. In this case we should not show the prompt as we do not want to confuse the user.

Looks to me like the code that needs to change is in nsBrowserGlue.js.

      if (telemetryNotifiedOptOut)
        return;

should be

      var telemetryEnabled = telemetryEnabledByDefault = Services.prefs.getBoolPref(PREF_TELEMETRY_ENABLED);
      var telemetryRejected = telemetryEnabledByDefault = Services.prefs.getBoolPref(PREF_TELEMETRY_REJECTED);
      var telemetryChosen = telemetryEnabled || telemetryRejected;
      if (telemetryNotifiedOptOut || telemetryChosen)
        return;

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

I think this is what you were proposing, Lawrence.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Nathan Froyd (:froydnj) from comment #1)
> I think this is what you were proposing, Lawrence.

Yes it is. Thanks for the quick turnaround.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I think that if we revisit bug 699806 per my latest comment there, we won't need to worry about handling all of these cases separately, and this patch will be unnecessary.

Comment 4

[Marco Bonardo [:mak]]

tentatively assigning to Theo, regardless we need to fix this along with bug 699806, even if just in the patch there.

Comment 5

[Théo Chevalier]

Closing this bug since we fixed it in bug 699806 for desktop and bug 725987 for mobile.