73355 - Clean up (get rid of?) prefutilities.js

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Peter "jag" Annema]

prefutilities.js has a lot of code that could (and should) move into the only
xul file that uses it (set homepage function to pref-navigator.xul/js, history
stuff to pref-history.xul).

Comment 1

[Mark Olson]

Attachment: jag's thoughts on the matter (untested)

Comment 2

[Mark Olson]

Alec, Ben;
Would like your opinion(s) if you have one on whether or not prefutilities.js
should be split up and cvs removed.  Most of the functions defined there are
only used in one place, so we don't seem to be getting much code sharing benefit
here.

Comment 3

[Mark Olson]

For whatever reason, our lovely new bugzilla system excluded alecf and ben in
that last update.  Trying again. - Could you guys jot your opinions down please?

Comment 4

[Mark Olson]

The prefutilities stuff looks good jag.

Now do we want another bug for nsJSComponentManager.js, since it looks like a
pretty thin wrapper? - If someone wants to wrap their getService or
createInstance in a try {}, should we force them do it at the callsite?

Comment 5

[Mark Olson]

r=mao

Comment 6

[Mark Olson]

Attachment: patch - remove build references to prefutilities.js

Comment 7

[timeless]

r=timeless (we really should get those chrome makefiles killed).

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

sr=ben

Comment 9

[Peter "jag" Annema]

+    var urlBarHistory =
Components.classes["@mozilla.org/browser/urlbarhistory;1"]
+                                 
.getService(Components.interfaces.nsIUrlbarHistory);
+    urlBarHist.clearHistory();

Spot the bug... Fixed locally :-)

| function prefCacheSelectFolder()

It looks like that function isn't used any longer.

I'll just check this in anyway in case someone wants to turn that back on again.

Comment 10

[Peter "jag" Annema]

Checked in, marking fixed.

Comment 11

[Peter "jag" Annema]

extensions/p3p is referencing prefutilities.js and strres.js. This is unreviewed
code (and not part of the build) which was checked in to make review easier (or
so I've been told), therefore I haven't bothered fixing it nor waiting for
another round of r=/sr=, but treated it as if wasn't checked in yet. I've mailed
the author he could safely remove the prefutilities.js and strres.js inclusions
from his code.

Comment 12

[sairuh (rarely reading bugmail)]

vrfy fixed: checked my linux debug and verif/pkg'd builds and prefutlities.js is
no longer around.

also checked lxr, and now that file is only mentioned in pref-P3P.xul and
pref-P3Pcust.xul. [but as jag said, he's already pinged the owner of those.]