Closed
Bug 733612
Opened 12 years ago
Closed 12 years ago
Add a pseudo-class lock menu to the infobar node menu
Categories
(DevTools :: Inspector, defect, P1)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: harth, Assigned: harth)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 3 obsolete files)
5.80 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
We need to add the pseudo-class lock menuitems to the infobar node menu from bug 717916. They are currently in a context menu, added in bug 707740.
Assignee | ||
Comment 1•12 years ago
|
||
This patch adds the pseudo-class lock menu items to the infobar's node menu. It also removes them from the infobar's context menu.
Assignee: nobody → fayearthur
Attachment #603974 -
Flags: review?(paul)
Assignee | ||
Comment 2•12 years ago
|
||
Sorry, here's the real patch.
Attachment #603974 -
Attachment is obsolete: true
Attachment #603975 -
Flags: review?(paul)
Attachment #603974 -
Flags: review?(paul)
Updated•12 years ago
|
Attachment #603975 -
Attachment is patch: true
Comment 3•12 years ago
|
||
Comment on attachment 603975 [details] [diff] [review] Add pseudo-class lock menu to node menu and remove from context menu Review of attachment 603975 [details] [diff] [review]: ----------------------------------------------------------------- r=+ with the new className. ::: browser/devtools/highlighter/highlighter.jsm @@ +500,5 @@ > + let separator = this.chromeDoc.createElement("menuseparator"); > + menu.appendChild(separator); > + > + menu.addEventListener("popupshowing", function() { > + let items = menu.getElementsByClassName("pseudo-class-menuitem"); I usually prefer menu.querySelectorAll(".pseudo-class-menuitem") (Up to you) @@ +557,4 @@ > let item = this.chromeDoc.createElement("menuitem"); > item.setAttribute("type", "checkbox"); > item.setAttribute("label", pseudo); > + item.className = "pseudo-class-menuitem"; Can you prefix the class with: "highlighter-"? Like: highlighter-pseudo-class-menuitem
Attachment #603975 -
Flags: review?(paul) → review+
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 5•12 years ago
|
||
I realise we don't have any test for that. Can we get one before landing this?
Comment 6•12 years ago
|
||
@harth, can you do it, or do you want me to do it?
Assignee | ||
Comment 7•12 years ago
|
||
New patch, updated and with a test.
Attachment #603975 -
Attachment is obsolete: true
Attachment #615680 -
Flags: review?(paul)
Assignee | ||
Comment 8•12 years ago
|
||
As discussed on irc, we want to reposition the infobar when the pseudo-class is added to the selector. This new patch includes this.
Attachment #615680 -
Attachment is obsolete: true
Attachment #615686 -
Flags: review?
Attachment #615680 -
Flags: review?(paul)
Assignee | ||
Updated•12 years ago
|
Attachment #615686 -
Flags: review? → review?(paul)
Updated•12 years ago
|
Attachment #615686 -
Flags: review?(paul) → review+
Updated•12 years ago
|
Whiteboard: [firefox14-wanted] → [land-in-fx-team]
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/integration/fx-team/rev/0ba7e290a08f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0ba7e290a08f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•