733627 - nsWindow::GetNonClientMargins() is using ::GetSystemMetrics(SM_CYFRAME) for both horizontal and vertical borders

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#1933

1932 NS_IMETHODIMP
1933 nsWindow::GetNonClientMargins(nsIntMargin &margins)
1934 {
1935   nsWindow * window = GetTopLevelWindow(true);
1936   if (window && window != this) {
1937     return window->GetNonClientMargins(margins);
1938   }
1939 
1940   if (mCustomNonClient) {
1941     margins = mNonClientMargins;
1942     return NS_OK;
1943   }
1944 
1945   margins.top = GetSystemMetrics(SM_CYCAPTION);
1946   margins.bottom = GetSystemMetrics(SM_CYFRAME);
1947   margins.top += margins.bottom;
1948   margins.left = margins.right = GetSystemMetrics(SM_CYFRAME);
1949 
1950   return NS_OK;
1951 }

#1948 should be SM_CXFRAME.

I don't know how to set different size for both borders.

Comment 1

[Masatoshi Kimura [:emk]]

> I don't know how to set different size for both borders.
Long time ago, device pixels were not square on some video modes. (such as CGA 640 x 200 mode)

Comment 2

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Comment on attachment 631355 [details] [diff] [review]
Patch(v1)

Thank you for the patch. I think this is right. Requesting r to jimm.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Landed on inbound. It'll be merged to mozilla-central in a day if it passes all tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf39986528f8

Thank you.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf39986528f8