Closed Bug 733633 Opened 8 years ago Closed 8 years ago

Inline settings of type=control only let buttons and menulists be in the input-container

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: Unfocused, Assigned: darktrojan)

References

Details

Attachments

(1 file)

Discovered during bug 335781, inline settings of type=control only allow buttons and menulists in the input-container.

This means that if you want a textbox not tied to a preference, the textbox is positinoed below the label, rather than to the right (and lined up with all the other controls).

If preferences-description needs to contain any random element (I don't know the history there), then input-container should at least be able to contain box/hbox/vbox as a workaround.
The control type is a leftover from when it was just mobile using the bindings (I don't know the history behind that either). For your textbox case, just use <setting type="text" title="..."> (no pref attribute).

Also, I think I can get rid of the <children> element in preferences-description now that we're just using attributes.
(In reply to Geoff Lankow (:darktrojan) from comment #1)
> Also, I think I can get rid of the <children> element in
> preferences-description now that we're just using attributes.

Oh, I already did this.
(In reply to Geoff Lankow (:darktrojan) from comment #1)
> For your textbox
> case, just use <setting type="text" title="..."> (no pref attribute).

Oh, forgot it supported that. The documentation suggests that attribute is required.

(In reply to Geoff Lankow (:darktrojan) from comment #2)
> (In reply to Geoff Lankow (:darktrojan) from comment #1)
> > Also, I think I can get rid of the <children> element in
> > preferences-description now that we're just using attributes.
> 
> Oh, I already did this.

Indeed - so for control=type, the <children/> in input-container can have it's filter removed. I can imagine it being useful for settings requiring a more complex UI.
Attached patch patchSplinter Review
Attachment #603632 - Flags: review?(bmcbride)
Attachment #603632 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb189b6b0b9
Flags: in-testsuite-
Flags: in-litmus-
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/5bb189b6b0b9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.