Closed
Bug 733652
Opened 12 years ago
Closed 12 years ago
remove geolocation address
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: dougt, Assigned: dougt)
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file)
38.49 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
Remove geolocation address from API. Blog post forthcoming.
Attachment #603577 -
Flags: review?(josh)
Comment 1•12 years ago
|
||
Comment on attachment 603577 [details] [diff] [review] patch v.1 Wow, we should delete API features more often. Should we consider holding off on landing this until after the merge next week?
Attachment #603577 -
Flags: review?(josh) → review+
Updated•12 years ago
|
Keywords: addon-compat,
dev-doc-needed
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 603577 [details] [diff] [review] patch v.1 it probably doesn't matter all that much. The desktop doesn't support this now since GLS (the default location service for Firefox desktop) doesn't ever return an address.
Comment 3•12 years ago
|
||
Sorry, push backed out for OS X M1/M3 oranges: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c619bbb2951f https://tbpl.mozilla.org/php/getParsedLog.php?id=10039398&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=10039239&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/ec55dae77b79
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/691063f2a50e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Comment 5•12 years ago
|
||
Documentation updated: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMGeoPositionAddress And mentioned on Firefox 14 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Comment 6•12 years ago
|
||
Just happened to visit this from the AMO blog. This was backed out, so shouldn't be marked fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•12 years ago
|
||
ed, thanks for double checking. I have confirmed that this patch did stick and we have removed geolocation address.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•