Closed Bug 733653 Opened 8 years ago Closed 8 years ago
Device Orientation - Use a default value of 100ms as the sensor interval
No description provided.
Comment on attachment 603578 [details] [diff] [review] patch v.1 This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.
Attachment #603578 - Flags: review?(josh) → review-
Comment on attachment 603578 [details] [diff] [review] patch v.1 ah.. good call. I only edited the android implementation
I couldn't really think if a reason why having a preference for the update interval was needed.
Comment on attachment 603598 [details] [diff] [review] patch .2 This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.
Attachment #603598 - Flags: review?(josh) → review-
Sorry, backed out for OS X M1/M3 oranges: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c619bbb2951f https://tbpl.mozilla.org/php/getParsedLog.php?id=10039398&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=10039239&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/ec55dae77b79
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.