733653 - Device Orientation - Use a default value of 100ms as the sensor interval

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 603578 [details] [diff] [review]
patch v.1

This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 603578 [details] [diff] [review]
patch v.1

ah.. good call.  I only edited the android implementation

Comment 4

[Doug Turner (:dougt)]

Attachment: patch .2

I couldn't really think if a reason why having a preference for the update interval was needed.

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 603598 [details] [diff] [review]
patch .2

This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.

Comment 6

[Ed Morley [:emorley]]

Sorry, backed out for OS X M1/M3 oranges:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c619bbb2951f
https://tbpl.mozilla.org/php/getParsedLog.php?id=10039398&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=10039239&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec55dae77b79

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/2aef3c754ff5