Closed
Bug 733653
Opened 12 years ago
Closed 12 years ago
Device Orientation - Use a default value of 100ms as the sensor interval
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file, 1 obsolete file)
5.98 KB,
patch
|
jdm
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #603578 -
Flags: review?(josh)
Comment 2•12 years ago
|
||
Comment on attachment 603578 [details] [diff] [review] patch v.1 This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.
Attachment #603578 -
Flags: review?(josh) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 603578 [details] [diff] [review] patch v.1 ah.. good call. I only edited the android implementation
Assignee | ||
Comment 4•12 years ago
|
||
I couldn't really think if a reason why having a preference for the update interval was needed.
Attachment #603578 -
Attachment is obsolete: true
Attachment #603598 -
Flags: review?(josh)
Comment 5•12 years ago
|
||
Comment on attachment 603598 [details] [diff] [review] patch .2 This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.
Attachment #603598 -
Flags: review?(josh) → review-
Comment 6•12 years ago
|
||
Sorry, backed out for OS X M1/M3 oranges: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c619bbb2951f https://tbpl.mozilla.org/php/getParsedLog.php?id=10039398&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=10039239&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/ec55dae77b79
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2aef3c754ff5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•