Device Orientation - Use a default value of 100ms as the sensor interval

RESOLVED FIXED in mozilla14

Status

()

Core
Geolocation
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 603578 [details] [diff] [review]
patch v.1
Attachment #603578 - Flags: review?(josh)

Comment 2

5 years ago
Comment on attachment 603578 [details] [diff] [review]
patch v.1

This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.
Attachment #603578 - Flags: review?(josh) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 603578 [details] [diff] [review]
patch v.1

ah.. good call.  I only edited the android implementation
(Assignee)

Comment 4

5 years ago
Created attachment 603598 [details] [diff] [review]
patch .2

I couldn't really think if a reason why having a preference for the update interval was needed.
Attachment #603578 - Attachment is obsolete: true
Attachment #603598 - Flags: review?(josh)

Comment 5

5 years ago
Comment on attachment 603598 [details] [diff] [review]
patch .2

This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.
Attachment #603598 - Flags: review?(josh) → review-

Comment 6

5 years ago
Sorry, backed out for OS X M1/M3 oranges:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=c619bbb2951f
https://tbpl.mozilla.org/php/getParsedLog.php?id=10039398&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=10039239&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec55dae77b79
https://hg.mozilla.org/mozilla-central/rev/2aef3c754ff5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Depends on: 1055939
You need to log in before you can comment on or make changes to this bug.