Last Comment Bug 733653 - Device Orientation - Use a default value of 100ms as the sensor interval
: Device Orientation - Use a default value of 100ms as the sensor interval
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Doug Turner (:dougt)
:
:
Mentors:
Depends on: 1055939
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-06 19:05 PST by Doug Turner (:dougt)
Modified: 2014-11-07 20:45 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (3.94 KB, patch)
2012-03-06 19:06 PST, Doug Turner (:dougt)
josh: review-
Details | Diff | Splinter Review
patch .2 (5.98 KB, patch)
2012-03-06 21:56 PST, Doug Turner (:dougt)
josh: review-
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2012-03-06 19:05:50 PST

    
Comment 1 Doug Turner (:dougt) 2012-03-06 19:06:33 PST
Created attachment 603578 [details] [diff] [review]
patch v.1
Comment 2 Josh Matthews [:jdm] 2012-03-06 21:15:57 PST
Comment on attachment 603578 [details] [diff] [review]
patch v.1

This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.
Comment 3 Doug Turner (:dougt) 2012-03-06 21:45:26 PST
Comment on attachment 603578 [details] [diff] [review]
patch v.1

ah.. good call.  I only edited the android implementation
Comment 4 Doug Turner (:dougt) 2012-03-06 21:56:53 PST
Created attachment 603598 [details] [diff] [review]
patch .2

I couldn't really think if a reason why having a preference for the update interval was needed.
Comment 5 Josh Matthews [:jdm] 2012-03-06 22:41:11 PST
Comment on attachment 603598 [details] [diff] [review]
patch .2

This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.
Comment 7 Matt Brubeck (:mbrubeck) 2012-03-14 10:09:37 PDT
https://hg.mozilla.org/mozilla-central/rev/2aef3c754ff5

Note You need to log in before you can comment on or make changes to this bug.