Closed Bug 733653 Opened 8 years ago Closed 8 years ago

Device Orientation - Use a default value of 100ms as the sensor interval

Categories

(Core :: DOM: Geolocation, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch v.1 (obsolete) — Splinter Review
Attachment #603578 - Flags: review?(josh)
Comment on attachment 603578 [details] [diff] [review]
patch v.1

This looks ok, but we should tie this in with nsDeviceMotion::mUpdateInterval. Currently that's set to device.motion.update.interval or 50, so the change in nsDeviceMotion.cpp doesn't actually reflect reality.
Attachment #603578 - Flags: review?(josh) → review-
Comment on attachment 603578 [details] [diff] [review]
patch v.1

ah.. good call.  I only edited the android implementation
Attached patch patch .2Splinter Review
I couldn't really think if a reason why having a preference for the update interval was needed.
Attachment #603578 - Attachment is obsolete: true
Attachment #603598 - Flags: review?(josh)
Comment on attachment 603598 [details] [diff] [review]
patch .2

This won't build; all platform-specific implementations use mUpdateInterval for the timer to trigger updates.
Attachment #603598 - Flags: review?(josh) → review-
https://hg.mozilla.org/mozilla-central/rev/2aef3c754ff5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Depends on: 1055939
You need to log in before you can comment on or make changes to this bug.