Closed Bug 733742 Opened 12 years ago Closed 12 years ago

Failure in testDisabledPermissions | XPath of element has been changed

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: remus.pop, Assigned: remus.pop)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(2 files, 1 obsolete file)

The failure states that Controller.assertJSProperty(XPath: /*[name()="window"]/*[name()="popupset"][1]/*[name()="menupopup"][4]/*[name()="menuitem"][1]) : true == false

This happens on Nightly on all platforms since 29th of February.

Actually we are not getting the correct item so this one will be an easy fix
The XPath of the element changed so here's the fix.
Attachment #603691 - Flags: review?(vlad.mozbugs)
Comment on attachment 603691 [details] [diff] [review]
patch v1 (default) [landed]

No comments. This was an easy one :) 
Over to Anthony
Attachment #603691 - Flags: review?(vlad.mozbugs)
Attachment #603691 - Flags: review?(anthony.s.hughes)
Attachment #603691 - Flags: review+
Attachment #603691 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 603691 [details] [diff] [review]
patch v1 (default) [landed]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/93bd95f6a066 (default)
Attachment #603691 - Attachment description: patch v1 (default) → patch v1 (default) [landed]
Please verify this is fixed with tomorrow's testrun.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
No failures on nightly.
http://bit.ly/AsRqXV
Status: RESOLVED → VERIFIED
Now fails in Aurora. A fix will soon be provided.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed the xpath.
Attachment #607108 - Flags: review?(anthony.s.hughes)
Attachment #607108 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 607108 [details] [diff] [review]
fix v1 (aurora) [backed-out]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/10f8e5cd6298 (mozilla-aurora)
Attachment #607108 - Attachment description: patch v1 (aurora) → fix v1 (aurora) [landed]
Please verify with tomorrow's testrun.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Attached patch fix v2 (aurora) (obsolete) — Splinter Review
Changed to XPath again.
Attachment #610465 - Flags: review?(hskupin)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So why do we have to flip-flop here? Was it a recent change in Aurora? If yes which checkin caused this problem? If not why have we checked in a broken xpath change?

We should not land a new patch but backout attachment 607108 [details] [diff] [review] instead.
Not sure where I went wrong. Probably I mixed some versions.
Yes, it can be back out.
Attachment #610465 - Attachment is obsolete: true
Attachment #610465 - Flags: review?(hskupin)
Comment on attachment 607108 [details] [diff] [review]
fix v1 (aurora) [backed-out]

Patch got backed out:
http://hg.mozilla.org/qa/mozmill-tests/rev/f772190394a9
Attachment #607108 - Attachment description: fix v1 (aurora) [landed] → fix v1 (aurora) [backed-out]
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: