73383 - Fix getting the root widget in nsViewManager::AddCoveringWidgetsToOpaqueRegion

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P2)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Kevin says:
> Should ask the viewmanager for the RootWidget using nsViewManager::GetWidget 
> instead of getting it out of the root view. A while back I put in support which 
> makes it possible to pass in a widget instead of requiring the root view to have
> a widget.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Proposed changes

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Kevin, the attached patch fixes all the places I can think of where we may need
to use the special widget for the root view. But how can I test this?

Comment 3

[Kevin McCluskey (gone)]

I have some code which removed the widgets created by the content viewer by
passing a widget to the view manager instead of creating a widget for the root
view. The bits for this have rotted and I don't have time right now to resurrect
them. Anyway, It's probably easier to start removing the content viewers
widget's from scratch since the content viewer code has changed substantially
since I made the initial attempt.


Your changes look good and move us back into a position which will allow us to
begin removing the content viewer widgets.

r=[e-mail]

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK Marc, I need your approval for this fix. Thanks!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Based on Kevin's comments, I guess this isn't really needed for Mozilla 0.9, but
I'd still like to check in ASAP.

Comment 6

[Marc Attinasi]

sr=[e-mail]

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in.

Comment 8

[Chris Petersen]

Marking verified per last comments