733831 - Kuma: present errors from kumascript

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Les Orchard [:lorchard]]

Errors can arise in kumascript processing from sources such as:

* parsing a document for macros
* loading and compiling templates
* executing templates

In the resolution of bug 730708 and bug 730709, these errors will be trapped and included in the headers of the response from the service. Page content will not contain the errors, and the service makes an attempt to recover gracefully by returning either the original source doc or doing something relatively non-disruptive with macros.

It will be up to the kuma wiki to accept these headers and do something useful by presenting them in the rendered view. Maybe an alert that the page had errors, and a revealable box logging the errors.

Comment 1

[Les Orchard [:lorchard]]

Progress:
https://github.com/mozilla/kuma/pull/135

Also, removing "usefully" from the title. This displays errors, but I think making the display *useful* will require some thought & design.

For example, it would be nice to link to or somehow show within the rendered document where errors occur. This doesn't do that.

Comment 2

[[github robot]]

Commits pushed to mdn at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/131af9d7c61e6b7a5b17f9c4ade3cd7a9d8039e3
bug 733831: Present errors from kumascript

* Request and parse errors from kumascript using the FireLogger protocol

* Add errors to the set of things cached for 304's

* Document view template changes to display errors

* Tests

https://github.com/mozilla/kuma/commit/51a225b9092289c1d4453ba15339f08887feabe1
bug 733831: Report when the kumascript service request times out or responds with some other error status

https://github.com/mozilla/kuma/commit/b02ff1730b252f41f1f8950b62a78addcb54f62e
Merge pull request #135 from lmorchard/bug-733831-present-kumascript-errors

Bug 733831 present kumascript errors

Comment 3

[[github robot]]

Commits pushed to mdn_prod at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/131af9d7c61e6b7a5b17f9c4ade3cd7a9d8039e3
bug 733831: Present errors from kumascript

https://github.com/mozilla/kuma/commit/51a225b9092289c1d4453ba15339f08887feabe1
bug 733831: Report when the kumascript service request times out or responds with some other error status

https://github.com/mozilla/kuma/commit/b02ff1730b252f41f1f8950b62a78addcb54f62e
Merge pull request #135 from lmorchard/bug-733831-present-kumascript-errors