734016 - navigator.mozApps.install on Success handler

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[[e-mail] [:onecyrenus]]

found a few inconsistencies with the html / js and the moz-central implementation. 

1)
navigator.mozApps.install();
Expected:
Error: install missing required url argument
Got:
Error: Not enough arguments [mozIDOMApplicationRegistry.install]   <-- is this a good enough error message ? 
 
2) navigator.mozApps.install 
receipts: null  in onsuccess: ←- in html / js
receipts: [] in onsuccess: ← in moz-central

3) navigator.mozApps.install in onSuccess
installTime = undefined in moz-central

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to [e-mail] from comment #0)
> 1)
> navigator.mozApps.install();
> Expected:
> Error: install missing required url argument
> Got:
> Error: Not enough arguments [mozIDOMApplicationRegistry.install]   <-- is
> this a good enough error message ? 

Welcome to XPConnect. All of our DOM APIs throw "helpful" error messages like that (try it with, say, window.addEventListener()).

Also, I think you mean "onsuccess" and not "onSuccess"?

Comment 2

[Philipp von Weitershausen [:philikon]]

(Also, moving to Core :: DOM since navigator.mozApps is part of the DOM, not Firefox.)

Comment 3

[Philipp von Weitershausen [:philikon]]

Don't mean to bikeshed, but the webapps API is hardly about "Device Interfaces"...

Comment 4

[[:fabrice] Fabrice Desré]

David,

1) what philikon said. This kind of error doesn't even reach the API implementation (which is not bad per se).

2) I'm happy to change the behavior on m-c, but is there a spec that defines this behavior?

3) that's a bug. Can you file it on its own?

Comment 5

[[e-mail] [:onecyrenus]]

2)

Comment 6

[[e-mail] [:onecyrenus]]

+ Adding anant to the thread to answer where the spec is defined. 

+ Filing a bug for issue 3. 

+ Updating the test, just wanted to make sure you were aware that the language was different. But I believe it would be good to standardize the text across each platform.

Comment 7

[Ian Bicking (:ianbicking)]

Submitted Bug 763072 to address 2 (specifically that the polyfill/html should copy moz-central).  The rest of the bug appears to have been addressed elsewhere.