734029 - Move nsJSContext::{Set,Create}OuterObject to nsGlobalWindow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

CreateOuterObject only has one caller, nsGlobalWindow::SetNewDocument. SetOuterObject has two, CreateOuterObject and SetNewDocument. It seems better to just move that code to nsGlobalWindow.cpp.

The only nsJSContext state these functions use is mContext, which we can get through GetNativeContext().

This will also allow us to make NS_NewOuterWindowProxy private to nsGlobalWindow.cpp.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=0e78df4b474c

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 604512 [details] [diff] [review]
Patch v1

>diff --git a/dom/base/nsIScriptContext.h b/dom/base/nsIScriptContext.h
>--- a/dom/base/nsIScriptContext.h
>+++ b/dom/base/nsIScriptContext.h
>@@ -89,16 +89,18 @@ NS_DEFINE_STATIC_IID_ACCESSOR(nsIScriptC
> class nsIScriptContext : public nsIScriptContextPrincipal
> {
> public:
>   NS_DECLARE_STATIC_IID_ACCESSOR(NS_ISCRIPTCONTEXT_IID)
> 
>   /* Get the ID of this language. */
>   virtual PRUint32 GetScriptTypeID() = 0;
> 
>+  virtual void SetGlobalObject(nsIScriptGlobalObject* aGlobalObject) = 0;
>+

It would be nice if this didn't have to be virtual, but maybe that de-agnostification is a task for another day. 

Nice patch - sorry for the delay. I wanted to take some time to really grok this stuff.

r=bholley

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/53ed280cc94b