Don't export __aeabi_* symbols from libmozglue.so on ARM

RESOLVED FIXED in mozilla13

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla13
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See http://glandium.org/blog/?p=2510 for some background.
Created attachment 604016 [details] [diff] [review]
Don't export __aeabi_* symbols from libmozglue.so on ARM
Attachment #604016 - Flags: review?(ted.mielczarek)
Comment on attachment 604016 [details] [diff] [review]
Don't export __aeabi_* symbols from libmozglue.so on ARM

Review of attachment 604016 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/build/Makefile.in
@@ +93,5 @@
>  SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,linker,../linker)
> +
> +ifeq (arm, $(TARGET_CPU))
> +EXTRA_DSO_LDOPTS += -Wl,-version-script,$(srcdir)/arm-eabi-filter
> +endif

We're guaranteed to only ever build MOZ_LINKER with GNU LD (or compatible)?
Attachment #604016 - Flags: review?(ted.mielczarek) → review+
> We're guaranteed to only ever build MOZ_LINKER with GNU LD (or compatible)?

MOZ_LINKER only supports ELF, so until it supports something else, yes.
OS: Linux → Android
Hardware: x86_64 → ARM
https://hg.mozilla.org/integration/mozilla-inbound/rev/66fc6fa2c347
Right, I'm just thinking of the variety of other *nix toolchains out there. Since we're only enabling this on Android it's probably not an issue.
https://hg.mozilla.org/mozilla-central/rev/66fc6fa2c347
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.