Closed
Bug 734046
Opened 12 years ago
Closed 12 years ago
Don't export __aeabi_* symbols from libmozglue.so on ARM
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
1.18 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
See http://glandium.org/blog/?p=2510 for some background.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #604016 -
Flags: review?(ted.mielczarek)
Comment 2•12 years ago
|
||
Comment on attachment 604016 [details] [diff] [review] Don't export __aeabi_* symbols from libmozglue.so on ARM Review of attachment 604016 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/build/Makefile.in @@ +93,5 @@ > SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,linker,../linker) > + > +ifeq (arm, $(TARGET_CPU)) > +EXTRA_DSO_LDOPTS += -Wl,-version-script,$(srcdir)/arm-eabi-filter > +endif We're guaranteed to only ever build MOZ_LINKER with GNU LD (or compatible)?
Attachment #604016 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•12 years ago
|
||
> We're guaranteed to only ever build MOZ_LINKER with GNU LD (or compatible)?
MOZ_LINKER only supports ELF, so until it supports something else, yes.
Assignee | ||
Updated•12 years ago
|
OS: Linux → Android
Hardware: x86_64 → ARM
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/66fc6fa2c347
Comment 5•12 years ago
|
||
Right, I'm just thinking of the variety of other *nix toolchains out there. Since we're only enabling this on Android it's probably not an issue.
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66fc6fa2c347
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•