Closed
Bug 734063
Opened 13 years ago
Closed 6 years ago
Remove the multicol element from nsContentUtils::IsHTMLBlock
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: hsivonen, Assigned: dpino)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
1.38 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
The HTML5 parser doesn't know about multicol. The plain text serializer and editor probably shouldn't, either.
|
||
Updated•8 years ago
|
Priority: -- → P3
|
Reporter | |
Updated•6 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 1•6 years ago
|
||
Here's a patch. I initially thought it'd involve more changes.
Attachment #9016787 -
Flags: review?(hsivonen)
|
|
Reporter | |
Updated•6 years ago
|
Attachment #9016787 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e763ffe1dac6b70d9f41849e2e28c222e9beb90
|
|
Assignee | |
Comment 3•6 years ago
|
||
Treeherder looks good. OTOH, I cannot commit. I'd need to get the bug assigned so I can edit it and add tag "checkin-needed", or somebody has to commit for me.
|
|
Reporter | |
Comment 4•6 years ago
|
||
Thanks! (Edited the assignment, etc.)
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4a64c835820 Remove the multicol element from nsContentUtils::IsHTMLBlock r=hsivonen
Keywords: checkin-needed
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c4a64c835820
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•