If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mochitest-chrome: 'test_chromeWorkerJSM.xul > WorkerTest_subworker.js' miss to actually use its chromeURL variable

ASSIGNED
Assigned to

Status

()

Core
DOM
P3
normal
ASSIGNED
6 years ago
4 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10 wontfix, firefox11 wontfix, firefox12 affected, firefox13 affected)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 604060 [details] [diff] [review]
(Av1) Load chromeURL (not mochitestURL) through XHR

This should be (part of) the fix, based on comment in the file.

But I get
[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1 SeaMonkey/2.9a1] (custom debug build for Windows 2000)
{
2 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/workers/te
st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception: DOMExcept
ion: INVALID_STATE_ERR
}
... :-/
Attachment #604060 - Flags: review?(jonas)
Attachment #604060 - Flags: review?(bent.mozilla)
(Assignee)

Comment 2

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)

[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120104 Firefox/12.0a1 SeaMonkey/2.9a1] (nightly, 2012-01-04-00-30-16-comm-central-trunk)
in fact.
Comment on attachment 604060 [details] [diff] [review]
(Av1) Load chromeURL (not mochitestURL) through XHR

Review of attachment 604060 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/WorkerTest_subworker.js
@@ +12,5 @@
>                                          "http://mochi.test:8888/tests");
>  
>    // We should be able to XHR to anything we want, including a chrome URL.
>    let xhr = new XMLHttpRequest();
> +  xhr.open("GET", chromeURL, false);

Rather than replacing this can you also make sure that we can xhr to the mochitestURL *and* the chrome URL?
(Assignee)

Comment 4

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> But I get
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)
> {
> 2 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/dom/workers/te
> st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception:
> DOMExcept
> ion: INVALID_STATE_ERR
> }
> ... :-/

That was because 'WorkerTest_badworker.js' is a "plain" test file, not a "chrome" test file!
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
status-firefox13: --- → affected
Target Milestone: mozilla13 → mozilla14
(Assignee)

Comment 5

6 years ago
Created attachment 605631 [details] [diff] [review]
(Av2) Enhance WorkerTest_subworker.js

Av1, with comment 3 suggestion(s),
and more.


[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

Please check that the expected test results I added are what they are supposed to be.
Attachment #604060 - Attachment is obsolete: true
Attachment #605631 - Flags: review?(bent.mozilla)
Attachment #604060 - Flags: review?(jonas)
Attachment #604060 - Flags: review?(bent.mozilla)
(Assignee)

Comment 6

6 years ago
Comment on attachment 605631 [details] [diff] [review]
(Av2) Enhance WorkerTest_subworker.js

Ping for review.
Attachment #605631 - Flags: review?(jonas)
I don't understand what is going on in this bug.

What is the problem you are trying to solve? Comment 0 is... not terribly descriptive.
(Assignee)

Comment 8

6 years ago
Created attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Av2, correctly rewritten.


(In reply to Jonas Sicking (:sicking) from comment #7)
> What is the problem you are trying to solve? Comment 0 is... not terribly
> descriptive.

Bug summary tells this test was apparently meant to test a chromeURL too, but missed to actually do so.
Eventually, I added more cases, fwiw.
Attachment #605631 - Attachment is obsolete: true
Attachment #611675 - Flags: review?(jonas)
Attachment #611675 - Flags: review?(bent.mozilla)
Attachment #605631 - Flags: review?(jonas)
Attachment #605631 - Flags: review?(bent.mozilla)
Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Ok. I think bent needs to review this since I don't know these tests well enough.
Attachment #611675 - Flags: review?(jonas)
(Assignee)

Comment 10

5 years ago
Ping for review.
Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Review of attachment 611675 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this slipped off my radar. How much of this still works?
Attachment #611675 - Flags: review?(bent.mozilla)
You need to log in before you can comment on or make changes to this bug.