Open
Bug 734077
Opened 13 years ago
Updated 3 years ago
mochitest-chrome: 'test_chromeWorkerJSM.xul > WorkerTest_subworker.js' miss to actually use its chromeURL variable
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
NEW
mozilla14
People
(Reporter: sgautherie, Unassigned)
References
()
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
Reporter | ||
Comment 1•13 years ago
|
||
This should be (part of) the fix, based on comment in the file.
But I get
[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1 SeaMonkey/2.9a1] (custom debug build for Windows 2000)
{
2 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/workers/te
st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception: DOMExcept
ion: INVALID_STATE_ERR
}
... :-/
Attachment #604060 -
Flags: review?(jonas)
Attachment #604060 -
Flags: review?(bent.mozilla)
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)
[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120104 Firefox/12.0a1 SeaMonkey/2.9a1] (nightly, 2012-01-04-00-30-16-comm-central-trunk)
in fact.
Comment on attachment 604060 [details] [diff] [review]
(Av1) Load chromeURL (not mochitestURL) through XHR
Review of attachment 604060 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/workers/test/WorkerTest_subworker.js
@@ +12,5 @@
> "http://mochi.test:8888/tests");
>
> // We should be able to XHR to anything we want, including a chrome URL.
> let xhr = new XMLHttpRequest();
> + xhr.open("GET", chromeURL, false);
Rather than replacing this can you also make sure that we can xhr to the mochitestURL *and* the chrome URL?
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> But I get
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)
> {
> 2 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/dom/workers/te
> st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception:
> DOMExcept
> ion: INVALID_STATE_ERR
> }
> ... :-/
That was because 'WorkerTest_badworker.js' is a "plain" test file, not a "chrome" test file!
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
status-firefox13:
--- → affected
Target Milestone: mozilla13 → mozilla14
Reporter | ||
Comment 5•13 years ago
|
||
Av1, with comment 3 suggestion(s),
and more.
[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)
Please check that the expected test results I added are what they are supposed to be.
Attachment #604060 -
Attachment is obsolete: true
Attachment #605631 -
Flags: review?(bent.mozilla)
Attachment #604060 -
Flags: review?(jonas)
Attachment #604060 -
Flags: review?(bent.mozilla)
Reporter | ||
Comment 6•13 years ago
|
||
Comment on attachment 605631 [details] [diff] [review]
(Av2) Enhance WorkerTest_subworker.js
Ping for review.
Attachment #605631 -
Flags: review?(jonas)
I don't understand what is going on in this bug.
What is the problem you are trying to solve? Comment 0 is... not terribly descriptive.
Reporter | ||
Comment 8•13 years ago
|
||
Av2, correctly rewritten.
(In reply to Jonas Sicking (:sicking) from comment #7)
> What is the problem you are trying to solve? Comment 0 is... not terribly
> descriptive.
Bug summary tells this test was apparently meant to test a chromeURL too, but missed to actually do so.
Eventually, I added more cases, fwiw.
Attachment #605631 -
Attachment is obsolete: true
Attachment #611675 -
Flags: review?(jonas)
Attachment #611675 -
Flags: review?(bent.mozilla)
Attachment #605631 -
Flags: review?(jonas)
Attachment #605631 -
Flags: review?(bent.mozilla)
Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files
Ok. I think bent needs to review this since I don't know these tests well enough.
Attachment #611675 -
Flags: review?(jonas)
Reporter | ||
Comment 10•13 years ago
|
||
Ping for review.
Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files
Review of attachment 611675 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry this slipped off my radar. How much of this still works?
Attachment #611675 -
Flags: review?(bent.mozilla)
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Updated•3 years ago
|
Severity: normal → S3
Comment 13•3 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•