734077 - mochitest-chrome: 'test_chromeWorkerJSM.xul > WorkerTest_subworker.js' miss to actually use its chromeURL variable

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Load chromeURL (not mochitestURL) through XHR

This should be (part of) the fix, based on comment in the file.

But I get
[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1 SeaMonkey/2.9a1] (custom debug build for Windows 2000)
{
2 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/workers/te
st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception: DOMExcept
ion: INVALID_STATE_ERR
}
... :-/

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)

[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120104 Firefox/12.0a1 SeaMonkey/2.9a1] (nightly, 2012-01-04-00-30-16-comm-central-trunk)
in fact.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 604060 [details] [diff] [review]
(Av1) Load chromeURL (not mochitestURL) through XHR

Review of attachment 604060 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/WorkerTest_subworker.js
@@ +12,5 @@
>                                          "http://mochi.test:8888/tests");
>  
>    // We should be able to XHR to anything we want, including a chrome URL.
>    let xhr = new XMLHttpRequest();
> +  xhr.open("GET", chromeURL, false);

Rather than replacing this can you also make sure that we can xhr to the mochitestURL *and* the chrome URL?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> But I get
> [Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
> SeaMonkey/2.9a1] (custom debug build for Windows 2000)
> {
> 2 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/dom/workers/te
> st/test_chromeWorkerJSM.xul | Worker had an error: uncaught exception:
> DOMExcept
> ion: INVALID_STATE_ERR
> }
> ... :-/

That was because 'WorkerTest_badworker.js' is a "plain" test file, not a "chrome" test file!

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Enhance WorkerTest_subworker.js

Av1, with comment 3 suggestion(s),
and more.


[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

Please check that the expected test results I added are what they are supposed to be.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 605631 [details] [diff] [review]
(Av2) Enhance WorkerTest_subworker.js

Ping for review.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't understand what is going on in this bug.

What is the problem you are trying to solve? Comment 0 is... not terribly descriptive.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Av2, correctly rewritten.


(In reply to Jonas Sicking (:sicking) from comment #7)
> What is the problem you are trying to solve? Comment 0 is... not terribly
> descriptive.

Bug summary tells this test was apparently meant to test a chromeURL too, but missed to actually do so.
Eventually, I added more cases, fwiw.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Ok. I think bent needs to review this since I don't know these tests well enough.

Comment 10

[Serge Gautherie (:sgautherie)]

Ping for review.

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 611675 [details] [diff] [review]
(Av3) Enhance WorkerTest_subworker.js, Add missing ';' in various files

Review of attachment 611675 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this slipped off my radar. How much of this still works?

Comment 12

[Firefox Bug Husbandry Bot]

Bulk priority change, per :mdaly

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.