734172 - browser_save_resend_postdata.js and browser_aboutCrashes.js erroneously blamed for leaking 2 DOMWindows and 1 DocShell

Status: VERIFIED FIXED

(Testing :: Mochitest, defect)

Description

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9910719&tree=Firefox&full=1
Rev3 WINNT 6.1 mozilla-central debug test mochitest-other on 2012-03-08 06:30:34 PST for push 0337458a08ba
{
[toolkit/content/tests/browser/browser_save_resend_postdata.js]
  1 window(s) [url = about:blank]
  1 docShell(s)
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1331186151.1331190870.3486.gz&fulltext=1
Linux comm-central-trunk debug test mochitest-other on 2012/03/07 21:55:51
{
[toolkit/content/tests/browser/browser_save_resend_postdata.js]
  1 window(s) [url = about:blank]
  1 docShell(s)
}

Comment 1

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1336024558.1336031502.20286.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/05/02 22:55:58

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 624313 [details] [diff] [review]
patch

Review of attachment 624313 [details] [diff] [review]:
-----------------------------------------------------------------

Please note that while I'm fine with those changes I'm technically not the right one for reviewing mochitest suites changes.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Tim Taubert [:ttaubert] from comment #4)
> Please note that while I'm fine with those changes I'm technically not the
> right one for reviewing mochitest suites changes.

I think this change is simple enough and not really interesting outside the context of leaks.

http://hg.mozilla.org/integration/mozilla-inbound/rev/c220dcb86e4e

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/mozilla-central/rev/c220dcb86e4e
https://hg.mozilla.org/mozilla-central/rev/908e9a9acabd

Comment 7

[Serge Gautherie (:sgautherie)]

SM 2.12a1:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1337320632.1337325277.11695.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/05/17 22:57:12

V.Fixed