Closed
Bug 734250
Opened 13 years ago
Closed 12 years ago
Remove JS_LockGCThing
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: igor, Assigned: terrence)
References
Details
Attachments
(1 file)
|
7.67 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
[This is a follow up for bug 730234 comment 5]
In all practical cases JS_LockGCThing/JS_UnlockGCThing duplicates functionality of JS_AddRoot/JS_RemoveRoot while providing no efficiency benefits as both types of API are implemented via similar hashtables. So we should consider to keep only JS_AddRoot/JS_RemoveRoot and remove JS_LockGCThing/JS_UnlockGCThing.
|
Assignee | |
Comment 1•12 years ago
|
||
GenerationalGC cannot work with LockGCThing. We need to transition its users to the other rooting APIs and then kill it.
Summary: Consider removing JS_LockGCThing → Remove JS_LockGCThing
Target Milestone: --- → mozilla14
Version: unspecified → Other Branch
|
|
Assignee | |
Updated•12 years ago
|
Assignee: general → terrence
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: mozilla14 → ---
|
|
Assignee | |
Comment 2•12 years ago
|
||
With bug 851340 and bug 851568 this is no longer being held alive by anything.
Attachment #725487 -
Flags: review?(wmccloskey)
Comment on attachment 725487 [details] [diff] [review]
v0
Review of attachment 725487 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent!
Attachment #725487 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•