Closed Bug 734250 Opened 9 years ago Closed 8 years ago

Remove JS_LockGCThing

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: igor, Assigned: terrence)

References

Details

Attachments

(1 file)

[This is a follow up for bug 730234 comment 5]

In all practical cases JS_LockGCThing/JS_UnlockGCThing duplicates functionality of JS_AddRoot/JS_RemoveRoot while providing no efficiency benefits as both types of API are implemented via similar hashtables. So we should consider to keep only JS_AddRoot/JS_RemoveRoot and remove JS_LockGCThing/JS_UnlockGCThing.
Depends on: 734255
No longer depends on: 734255
Blocks: 730961
GenerationalGC cannot work with LockGCThing.  We need to transition its users to the other rooting APIs and then kill it.
Summary: Consider removing JS_LockGCThing → Remove JS_LockGCThing
Target Milestone: --- → mozilla14
Version: unspecified → Other Branch
Blocks: 764882
Assignee: general → terrence
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: mozilla14 → ---
Depends on: 850293
Depends on: 851568
Attached patch v0Splinter Review
With bug 851340 and bug 851568 this is no longer being held alive by anything.
Attachment #725487 - Flags: review?(wmccloskey)
Comment on attachment 725487 [details] [diff] [review]
v0

Review of attachment 725487 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #725487 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/955bd7967d96
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.