734259 - Clicking a system stylesheet in the style inspector does not open the source

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Rob Campbell [:rc] (:robcee)]

In the Inspector, click (deselect) Only Show User Styles in the Style Inspector (computed view). Expand a property to reveal a rule with a link to html.css.

Click the html.css link.

Expected: Should see html.css with the relevant rule displayed either in the source editor or view source.

Actual: Source Editor opens with an empty source editor.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Test case:
1. Inspect the Google logo
2. Open computed view
3. Expand "display"
4. Click on html.css

The style editor will open with a list of inline stylesheets. Because html.css is not listed in the style editor we do not open it.

Seems like we need to be able to switch the style editor into system mode so that system stylesheets can be loaded.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

We decided to open these links in view source because we don't want users to be editing UA css.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 604981 [details] [diff] [review]
Patch

Missing tests

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Tests now included

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 606294 [details] [diff] [review]
Tests now included

Review of attachment 606294 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good and all tests pass.

One general comment: tests use arguments.callee which is deprecated.

::: browser/devtools/highlighter/inspector.jsm
@@ +1031,2 @@
>  
> +    // Array.prototype.indexOf always returns -1 here so we loop through

Is this comment needed?

::: browser/devtools/styleinspector/test/browser_ruleview_bug_703643_context_menu_copy.js
@@ -46,5 @@
>  
>    // Make sure the inspector is open.
>    ok(InspectorUI.inspecting, "Inspector is highlighting");
>    ok(!InspectorUI.treePanel.isOpen(), "Inspector Tree Panel is not open");
> -  ok(!InspectorUI.isSidebarOpen, "Inspector Sidebar is not open");

Why is this here?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed orange

Comment 7

[Mihai Sucan [:msucan]]

Mike: the latest patch you submitted here is empty.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: patch included

Patch now included.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7c1729f6ba3b

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7c1729f6ba3b