Closed Bug 734280 Opened 9 years ago Closed 9 years ago

[New Tab Page] clean up newtab test suite

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Summary: [New Tab Page] replace or remove global variable 'cells' in tests → [New Tab Page] clean up newtab test suite
Attached patch patch v1Splinter Review
Here's what I did:

1) I removed the callback parameters from Site.block(), Site.unpin() and Drop.drop() because they were only used for testing purposes. Now that we have whenPagesUpdated() we can remove this entirely.

2) The global variables 'cells' and 'cw' are no longer and we now have some convenience functions to replace them.

3) I refactored checkGrid() because that was a hell of a function and can be written much smaller and easier.

4) I added sendDragEvent() and createDragEvent() to head.js to not violate the DRY principle - two tests had custom implementations of these functions.
Attachment #608655 - Flags: review?(dietrich)
Comment on attachment 608655 [details] [diff] [review]
patch v1

Review of attachment 608655 [details] [diff] [review]:
-----------------------------------------------------------------

yay globals--, r=me
Attachment #608655 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/fx-team/rev/5b1154a3289c
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/5b1154a3289c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Depends on: 742782
You need to log in before you can comment on or make changes to this bug.