The default bug view has changed. See this FAQ.

[New Tab Page] clean up newtab test suite

RESOLVED FIXED in Firefox 14

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Summary: [New Tab Page] replace or remove global variable 'cells' in tests → [New Tab Page] clean up newtab test suite
(Assignee)

Comment 1

5 years ago
Created attachment 608655 [details] [diff] [review]
patch v1

Here's what I did:

1) I removed the callback parameters from Site.block(), Site.unpin() and Drop.drop() because they were only used for testing purposes. Now that we have whenPagesUpdated() we can remove this entirely.

2) The global variables 'cells' and 'cw' are no longer and we now have some convenience functions to replace them.

3) I refactored checkGrid() because that was a hell of a function and can be written much smaller and easier.

4) I added sendDragEvent() and createDragEvent() to head.js to not violate the DRY principle - two tests had custom implementations of these functions.
Attachment #608655 - Flags: review?(dietrich)
(Assignee)

Comment 2

5 years ago
It's all green, whee! https://tbpl.mozilla.org/?tree=Try&rev=2e3c04e73f3f
Comment on attachment 608655 [details] [diff] [review]
patch v1

Review of attachment 608655 [details] [diff] [review]:
-----------------------------------------------------------------

yay globals--, r=me
Attachment #608655 - Flags: review?(dietrich) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/5b1154a3289c
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5b1154a3289c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

5 years ago
Depends on: 742782
You need to log in before you can comment on or make changes to this bug.