when installing an app the InstallTime is returning undefined

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Apps
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: onecyrenus, Assigned: ianb)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
navigator.mozApps.install in onSuccess

installTime = undefined

This is on mozilla-central.
(Reporter)

Updated

5 years ago
Blocks: 697006
Blocks: 720415
No longer blocks: 697006
(Reporter)

Comment 1

5 years ago
The difference I was seeing with the HTML / JS implementation here is that installTime in the onSuccess handler whereas in ff it is not. 

It seems more natural for this to be returned later in getInstalled, which is the way ff does it .
(Reporter)

Updated

5 years ago
Whiteboard: [mozApps API 1.0]

Updated

5 years ago
Component: DOM: Device Interfaces → DOM: Mozilla Extensions
QA Contact: device-interfaces → general

Updated

5 years ago
Blocks: 746465

Updated

5 years ago
Whiteboard: [mozApps API 1.0]
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 2

5 years ago
Created attachment 632103 [details] [diff] [review]
Fix for bug, plus test

One-line fix, plus MochiTest
Assignee: nobody → ianb
Attachment #632103 - Flags: review?(fabrice)
Comment on attachment 632103 [details] [diff] [review]
Fix for bug, plus test

Review of attachment 632103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/apps/src/Webapps.jsm
@@ +181,4 @@
>      }
>  
>      let appObject = this._cloneAppObject(app);
> +    appObject.installTime = app.installTime = (new Date()).getTime();

Nit: Date.now() is fine also
Attachment #632103 - Flags: review?(fabrice) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 634085 [details] [diff] [review]
Fix with nit addressed
Attachment #632103 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 634085 [details] [diff] [review]
Fix with nit addressed

https://hg.mozilla.org/integration/mozilla-inbound/rev/92aa87e1e876
Attachment #634085 - Flags: checkin+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/92aa87e1e876
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Component: DOM: Mozilla Extensions → DOM: Apps
You need to log in before you can comment on or make changes to this bug.