Closed Bug 734294 Opened 11 years ago Closed 10 years ago

when installing an app the InstallTime is returning undefined

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: onecyrenus, Assigned: ianbicking)

References

Details

Attachments

(1 file, 1 obsolete file)

navigator.mozApps.install in onSuccess

installTime = undefined

This is on mozilla-central.
Blocks: 697006
Blocks: 720415
No longer blocks: 697006
The difference I was seeing with the HTML / JS implementation here is that installTime in the onSuccess handler whereas in ff it is not. 

It seems more natural for this to be returned later in getInstalled, which is the way ff does it .
Whiteboard: [mozApps API 1.0]
Component: DOM: Device Interfaces → DOM: Mozilla Extensions
QA Contact: device-interfaces → general
Blocks: 746465
Whiteboard: [mozApps API 1.0]
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Fix for bug, plus test (obsolete) — Splinter Review
One-line fix, plus MochiTest
Assignee: nobody → ianb
Attachment #632103 - Flags: review?(fabrice)
Comment on attachment 632103 [details] [diff] [review]
Fix for bug, plus test

Review of attachment 632103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/apps/src/Webapps.jsm
@@ +181,4 @@
>      }
>  
>      let appObject = this._cloneAppObject(app);
> +    appObject.installTime = app.installTime = (new Date()).getTime();

Nit: Date.now() is fine also
Attachment #632103 - Flags: review?(fabrice) → review+
Attachment #632103 - Attachment is obsolete: true
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/92aa87e1e876
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM: Mozilla Extensions → DOM: Apps
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.