Last Comment Bug 734374 - Adjust the URL and search bar border color for Australis
: Adjust the URL and search bar border color for Australis
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- normal with 2 votes (vote)
: Firefox 14
Assigned To: Joshua M [:soapy]
:
Mentors:
Depends on:
Blocks: australis-navbar
  Show dependency treegraph
 
Reported: 2012-03-09 06:46 PST by Dão Gottwald [:dao]
Modified: 2012-04-05 01:47 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.80 KB, patch)
2012-03-09 11:59 PST, Joshua M [:soapy]
dao+bmo: review-
jaws: feedback+
Details | Diff | Review
Patch v2 (1.67 KB, patch)
2012-03-10 14:59 PST, Joshua M [:soapy]
dao+bmo: review+
Details | Diff | Review

Description Dão Gottwald [:dao] 2012-03-09 06:46:20 PST

    
Comment 1 Joshua M [:soapy] 2012-03-09 11:59:47 PST
Created attachment 604486 [details] [diff] [review]
Patch v1
Comment 2 Jared Wein [:jaws] (please needinfo? me) 2012-03-09 13:30:24 PST
Comment on attachment 604486 [details] [diff] [review]
Patch v1

Review of attachment 604486 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Comment 3 Dão Gottwald [:dao] 2012-03-10 09:06:52 PST
Comment on attachment 604486 [details] [diff] [review]
Patch v1

browser/themes/winstripe/browser.css already sets a transition for #urlbar, one of them will lose.

It's odd that this adds a box-shadow after we removed a similar one that Firefox 4 had...
Comment 4 Joshua M [:soapy] 2012-03-10 14:59:29 PST
Created attachment 604686 [details] [diff] [review]
Patch v2

Removed transition and box-shadow.
Comment 6 Ed Morley [:emorley] 2012-03-14 14:38:29 PDT
https://hg.mozilla.org/mozilla-central/rev/13d65ef93dc5

Note You need to log in before you can comment on or make changes to this bug.