734385 - special hosts errors on balrog dev servers

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

These started after bug 685862 landed. We should get the servers updated with the new configuration variable, but we should probably cope with this more gracefully....

I think there might be another bug, too. This line treats it like a string:
https://github.com/mozilla/balrog/commit/720ea0fc34fb96a19b47814e8015af81fed161d2#L0R156

But https://github.com/mozilla/balrog/commit/720ea0fc34fb96a19b47814e8015af81fed161d2#L2L0 implies that it's a tuple/iterable.

ERROR:auslib.client.base:Exception on /update/3/Firefox/13.0a1/20120305031045/Linux_x86_64-gcc3/en-US/nightly/Linux 3.2.0-1-amd64 (GTK 2.24.9)/default/default/update.xml [GET]
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1292, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1062, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1060, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1047, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib/python2.6/site-packages/flask/views.py", line 56, in view
    return self.dispatch_request(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/flask/views.py", line 112, in dispatch_request
    return meth(*args, **kwargs)
  File "/data/www/aus4-dev.allizom.org/auslib/client/views/client.py", line 59, in get
    xml = AUS.createXML(query, rule)
  File "/data/www/aus4-dev.allizom.org/auslib/AUS.py", line 215, in createXML
    rel = self.expandRelease(updateQuery, release)
  File "/data/www/aus4-dev.allizom.org/auslib/AUS.py", line 156, in expandRelease
    if updateQuery['force'] and url.startswith(self.specialForceHosts):
TypeError: expected a character buffer object
ERROR:auslib.client.views.client:Caught ISA 500 error.
DEBUG:auslib.client.views.client:Balrog version is: 0.1.1
DEBUG:auslib.client.views.client:Request path is: /update/3/Firefox/13.0a1/20120305031045/Linux_x86_64-gcc3/en-US/nightly/Linux 3.2.0-1-amd64 (GTK 2.24.9)/default/default/update.xml

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Fix special hosts

* fixes the mixed type handling of specialHosts by making it a tuple everywhere
* add tests for zero and two specialHosts, to supplement existing one specialHost tests
* adjust existing tests to make sure we always test, the for p in updateData['patches'] might shortcircuit to no checks at all

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 609267 [details] [diff] [review]
Fix special hosts

https://github.com/mozilla/balrog/commit/51e3ffec3fa3114c18bb6b54f70235ada244c11e

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Green on Jenkins - https://jenkins.mozilla.org/job/Balrog/64/ - and requests to aus4-dev with ?force=1 work now.