734401 - Protect async queries from syntax errors

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

When building and executing an async query no check is done on the query itself, since it's prepared on the first execution. This means that a typo/syntax would be invisible up to the runtime point.
To provide some sort of protection we should have no async queries without a callback (thus provide a default no-op callback) and fatal assert in all the handleError methods.

Comment 1

[Marco Bonardo [:mak]]

An alternative may be to hook up something in storage, a MOZ_ASSERT in it would be much better, though it's common to use it to test queries (for example in SQLite Manager) ans fatal assertions there would be quite bad.

A possibility could be to decorate the statements with a comment like
/* assert parsing */ SELECT ...
and parse the comment in debug mode to check if it should assert.