Closed Bug 734415 Opened 12 years ago Closed 12 years ago

IonMonkey: Specialize phis with int32 and double operands as double

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
With this patch Kraken gaussian-blur drops from 290 ms to 185 ms.
Attachment #604442 - Flags: review?(dvander)
Comment on attachment 604442 [details] [diff] [review]
Patch

Review of attachment 604442 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #604442 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/2eddf60c86e2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
If I'm reading this diff right.
Among other things you changed the following:

for (...) {
  if (type == MIRType_None) {
    ...
  } else if (type != in->type()) {
    ...
  }
}

into

for (...) {
  if (type == MIRType_None) {
    ...
    continue;
  }
  if (type != in->type()) {
    ...
  }
}

Also with changes on the "..." lines.
But I'm curious why altering "else if" into a "continue". 
Is there a specific reason for doing this?
(In reply to Hannes Verschore from comment #3)
>
> But I'm curious why altering "else if" into a "continue". 
> Is there a specific reason for doing this?

No important reason, it just seemed a bit more readable and it matched the other "if .. continue;" before it.
(In reply to Jan de Mooij (:jandem) from comment #4)
> No important reason, it just seemed a bit more readable and it matched the
> other "if .. continue;" before it.

Ah ... I was thinking there were some style rules unknown to me involved.
Nice win on kraken btw.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: