GC: missing barriers in InitExnPrivates

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
InitExnPrivate needs to trigger barriers when copying out to the heap, but not when copying data into the on-stack vector.
(Assignee)

Comment 1

5 years ago
Created attachment 605095 [details] [diff] [review]
v0

I verified that this patch fixes half the failures I am experiencing with my write buffer.
Attachment #605095 - Flags: review?(wmccloskey)
Comment on attachment 605095 [details] [diff] [review]
v0

Review of attachment 605095 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsexn.cpp
@@ +122,5 @@
> +typedef JSStackTraceElemImpl<HeapPtrString> JSStackTraceElem;
> +typedef JSStackTraceElemImpl<JSString *>    JSStackTraceStackElem;
> +
> +static void
> +copyTraceElemToHeap(JSStackTraceElem *dst, JSStackTraceStackElem *src)

Can you just put the code directly in the loop? If it's in a function, it's possible people will call it without realizing that it does init() rather than set().

Also, in general, functions like this should start with an uppercase letter.
Attachment #605095 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/da22cf5a850f
Target Milestone: --- → mozilla13
(Assignee)

Comment 4

5 years ago
Thanks for the help, bugzilla, but no.
Target Milestone: mozilla13 → ---
https://hg.mozilla.org/mozilla-central/rev/da22cf5a850f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.