734629 - /Developer/Tools is hardcoded, but doesn't exist anymore since Xcode 4.3

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nomis101]

We have a few hardcoded pathes /Developer/Tools in the code. But since Xcode 4.3, this path is now Xcode.app/Contents/Developer/Tools. Therefore e.g. packaging doesn't work anymore:

ln -s /Applications pkg-dmg.83980.vQhJ6uUJ/stage/\ 
rsync -a --copy-unsafe-links branding/disk.icns pkg-dmg.83980.vQhJ6uUJ/stage/.VolumeIcon.icns
/Developer/Tools/SetFile -a C pkg-dmg.83980.vQhJ6uUJ/stage
Can't exec "/Developer/Tools/SetFile": No such file or directory at /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg line 845.
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: exec: No such file or directory
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: SetFile failed (cleaning up)
make[1]: *** [make-package] Error 1
make: *** [default] Error 2

Comment 1

[Pierre Réveillon]

Attachment: Patch to use default system binary

This patch worked for me but may be not reliable!
On my system (Xcode 4.3 installed with AppStore), both SetFile and Rez have symlinks in /usr/bin.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 606607 [details] [diff] [review]
Patch to use default system binary

Review of attachment 606607 [details] [diff] [review]:
-----------------------------------------------------------------

Checked with someone with XCode 3.2.6, this should be fine.

Comment 3

[Bob Clary [:bc] (inactive)]

It would be nice to get this on Beta and Aurora after it has landed on mozilla-central.

Comment 4

[Landry Breuil (:gaston)]

Better to set checkin-needed in keywords rather than whiteboard :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/234f5e8bf794

Thanks for the patch! To make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you create. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/234f5e8bf794