Last Comment Bug 734629 - /Developer/Tools is hardcoded, but doesn't exist anymore since Xcode 4.3
: /Developer/Tools is hardcoded, but doesn't exist anymore since Xcode 4.3
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Pierre Réveillon
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-10 04:12 PST by Nomis101
Modified: 2012-07-27 09:55 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch to use default system binary (803 bytes, patch)
2012-03-16 09:48 PDT, Pierre Réveillon
mh+mozilla: review+
Details | Diff | Splinter Review

Description Nomis101 2012-03-10 04:12:05 PST
We have a few hardcoded pathes /Developer/Tools in the code. But since Xcode 4.3, this path is now Xcode.app/Contents/Developer/Tools. Therefore e.g. packaging doesn't work anymore:

ln -s /Applications pkg-dmg.83980.vQhJ6uUJ/stage/\ 
rsync -a --copy-unsafe-links branding/disk.icns pkg-dmg.83980.vQhJ6uUJ/stage/.VolumeIcon.icns
/Developer/Tools/SetFile -a C pkg-dmg.83980.vQhJ6uUJ/stage
Can't exec "/Developer/Tools/SetFile": No such file or directory at /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg line 845.
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: exec: No such file or directory
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: SetFile failed (cleaning up)
make[1]: *** [make-package] Error 1
make: *** [default] Error 2
Comment 1 Pierre Réveillon 2012-03-16 09:48:05 PDT
Created attachment 606607 [details] [diff] [review]
Patch to use default system binary

This patch worked for me but may be not reliable!
On my system (Xcode 4.3 installed with AppStore), both SetFile and Rez have symlinks in /usr/bin.
Comment 2 Mike Hommey [:glandium] 2012-05-01 23:02:12 PDT
Comment on attachment 606607 [details] [diff] [review]
Patch to use default system binary

Review of attachment 606607 [details] [diff] [review]:
-----------------------------------------------------------------

Checked with someone with XCode 3.2.6, this should be fine.
Comment 3 Bob Clary [:bc:] 2012-05-02 06:16:14 PDT
It would be nice to get this on Beta and Aurora after it has landed on mozilla-central.
Comment 4 Landry Breuil (:gaston) 2012-05-04 00:18:26 PDT
Better to set checkin-needed in keywords rather than whiteboard :)
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-05-04 19:51:52 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/234f5e8bf794

Thanks for the patch! To make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you create. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-05-05 20:23:45 PDT
https://hg.mozilla.org/mozilla-central/rev/234f5e8bf794

Note You need to log in before you can comment on or make changes to this bug.