Closed
Bug 734629
Opened 12 years ago
Closed 12 years ago
/Developer/Tools is hardcoded, but doesn't exist anymore since Xcode 4.3
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: Nomis101, Assigned: pierre)
References
()
Details
Attachments
(1 file)
803 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
We have a few hardcoded pathes /Developer/Tools in the code. But since Xcode 4.3, this path is now Xcode.app/Contents/Developer/Tools. Therefore e.g. packaging doesn't work anymore: ln -s /Applications pkg-dmg.83980.vQhJ6uUJ/stage/\ rsync -a --copy-unsafe-links branding/disk.icns pkg-dmg.83980.vQhJ6uUJ/stage/.VolumeIcon.icns /Developer/Tools/SetFile -a C pkg-dmg.83980.vQhJ6uUJ/stage Can't exec "/Developer/Tools/SetFile": No such file or directory at /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg line 845. /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: exec: No such file or directory /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: SetFile failed (cleaning up) make[1]: *** [make-package] Error 1 make: *** [default] Error 2
Assignee | ||
Comment 1•12 years ago
|
||
This patch worked for me but may be not reliable! On my system (Xcode 4.3 installed with AppStore), both SetFile and Rez have symlinks in /usr/bin.
Updated•12 years ago
|
Attachment #606607 -
Flags: review?(mh+mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 606607 [details] [diff] [review] Patch to use default system binary Review of attachment 606607 [details] [diff] [review]: ----------------------------------------------------------------- Checked with someone with XCode 3.2.6, this should be fine.
Attachment #606607 -
Flags: review?(mh+mozilla) → review+
Comment 3•12 years ago
|
||
It would be nice to get this on Beta and Aurora after it has landed on mozilla-central.
Assignee: nobody → pierre
Whiteboard: [checkin-needed]
Comment 4•12 years ago
|
||
Better to set checkin-needed in keywords rather than whiteboard :)
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/234f5e8bf794 Thanks for the patch! To make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you create. Thanks! https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/234f5e8bf794
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•