/Developer/Tools is hardcoded, but doesn't exist anymore since Xcode 4.3

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Nomis101, Assigned: Pierre Réveillon)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We have a few hardcoded pathes /Developer/Tools in the code. But since Xcode 4.3, this path is now Xcode.app/Contents/Developer/Tools. Therefore e.g. packaging doesn't work anymore:

ln -s /Applications pkg-dmg.83980.vQhJ6uUJ/stage/\ 
rsync -a --copy-unsafe-links branding/disk.icns pkg-dmg.83980.vQhJ6uUJ/stage/.VolumeIcon.icns
/Developer/Tools/SetFile -a C pkg-dmg.83980.vQhJ6uUJ/stage
Can't exec "/Developer/Tools/SetFile": No such file or directory at /Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg line 845.
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: exec: No such file or directory
/Volumes/Developer/comm-beta/mozilla/build/package/mac_osx/pkg-dmg: SetFile failed (cleaning up)
make[1]: *** [make-package] Error 1
make: *** [default] Error 2
(Assignee)

Comment 1

5 years ago
Created attachment 606607 [details] [diff] [review]
Patch to use default system binary

This patch worked for me but may be not reliable!
On my system (Xcode 4.3 installed with AppStore), both SetFile and Rez have symlinks in /usr/bin.

Updated

5 years ago
Attachment #606607 - Flags: review?(mh+mozilla)
Comment on attachment 606607 [details] [diff] [review]
Patch to use default system binary

Review of attachment 606607 [details] [diff] [review]:
-----------------------------------------------------------------

Checked with someone with XCode 3.2.6, this should be fine.
Attachment #606607 - Flags: review?(mh+mozilla) → review+

Comment 3

5 years ago
It would be nice to get this on Beta and Aurora after it has landed on mozilla-central.
Assignee: nobody → pierre
Whiteboard: [checkin-needed]
Better to set checkin-needed in keywords rather than whiteboard :)
Keywords: checkin-needed
Whiteboard: [checkin-needed]
https://hg.mozilla.org/integration/mozilla-inbound/rev/234f5e8bf794

Thanks for the patch! To make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you create. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/234f5e8bf794
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.