734640 - Inconsistent selection behavior when deleting history in treeviews

Status: NEW

(Toolkit :: Places, defect, P3)

Description

[Martin Petricek]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0
Build ID: 20111220165912

Steps to reproduce:

1. Open library, click on history, then type "/" to see all your history.
2. Select 6 consecutive items and press delete.
3. Select 7 consecutive items and press delete.


Actual results:

When selecting 6 or less consecutive items from history and then pressing the Delete key, focus in the list with history is set to next item after those that were deleted (so you can continue navigating the history by pressing up/down/pageup/pagedown keys ...).

However when selecting larger block (7 or more items) and pressing delete, the focus is unset from the component (and attempts to navigate the list using keyboard will reset you to the first item in the list)

This is inconsistent behavior and makes navigation by keyboard while selectively deleting items in the history much harder.


Expected results:

The focus should be set to next item after those that were deleted no matter how many items were selected.

Comment 1

[Alice0775 White]

Regression window(cached m-c)
Cannot reproduce
http://hg.mozilla.org/mozilla-central/rev/922f27baed98
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110831 Firefox/9.0a1 ID:20110831052659
Can reproduce:
http://hg.mozilla.org/mozilla-central/rev/6c9f2fbaec1b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110831 Firefox/9.0a1 ID:20110831080359
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=922f27baed98&tochange=6c9f2fbaec1b
Suspected: 
7a8b51e5be41	Marco Bonardo — Bug 681420 - Improve responsiveness of history deletion. r=dietrich sr=rstrong

Comment 2

[Marco Bonardo [:mak]]

in one case we do a batch, in the second case we do single removals. the selection is handled differently in those cases, may be bogus for the batch case. Ideally this should not be a real regression but just a shift in numbers (before probably we were batching sooner or later than at 6 changes)

Comment 3

[Chris Bellini (:cbellini)]

It's worth investigating the case where we batch the deletion operation (used in the case of a larger number of selected entries)