Closed Bug 734681 Opened 8 years ago Closed 8 years ago
Shutdown the decoder in Source
Data Complete() if decoding is already finished
For the BMP decoder we don't shutdown the decoder until we've decoded all the data, and we don't know that until SourceDataComplete() is called. If the decode worker decodes all the data before SourceDataComplete(), we won't do an UNTIL_SIZE decode and the decoder is shutdown asynchronously. This is a problem because the RasterImage doesn't notice some errors until the decoder is shutdown, which means that we'll sometimes fire onload when we otherwise would have fired onerror. I believe that this discrepancy is the cause of the reftest failures in bug 721917. Patch coming up shortly.
This changes UNTIL_SIZE decodes so that instead of returning early if the size is already known, we only skip the decoding loop. That way we'll check if decoding is finished and shutdown the decoder.
Assignee: nobody → rclickenbrock
Status: NEW → ASSIGNED
Don't forget to ask for review :)
Comment on attachment 604684 [details] [diff] [review] patch Right, I forgot the review flag. I'm out of town for the week, so no need to rush on the review. I'll address any review comments and do some try runs when I return.
Attachment #604684 - Flags: review?(joe)
Attachment #604684 - Flags: review?(joe) → review+
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=f1667d464be7
Try run for f1667d464be7 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=f1667d464be7 Results (out of 224 total builds): exception: 3 success: 188 warnings: 17 failure: 16 Builds (or logs if builds failed) available at: http://firstname.lastname@example.org
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.