Inline nsIScriptContext::ConnectToInner into its only caller

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 604753 [details] [diff] [review]
Patch v1
Attachment #604753 - Flags: review?(jst)
Comment on attachment 604753 [details] [diff] [review]
Patch v1

     nsCOMPtr<nsIContent> frame = do_QueryInterface(GetFrameElementInternal());
-    if (frame && frame->OwnerDoc()) {
+    if (frame) {

This looks unrelated, what triggered this change here? I think it's probably a correct change, but I'd need to look a bit deeper to verify, unless you already did :)
(Assignee)

Comment 2

5 years ago
OwnerDoc() never returns null (since strong-parent-node), so I tend to remove null checks when I spot them. Can drop it from this patch if you prefer
Comment on attachment 604753 [details] [diff] [review]
Patch v1

Good point. Some day I will remember that myself too :)
Attachment #604753 - Flags: review?(jst) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9fdfd263167b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.