Closed Bug 734724 Opened 8 years ago Closed 8 years ago

Inline nsIScriptContext::ConnectToInner into its only caller

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #604753 - Flags: review?(jst)
Comment on attachment 604753 [details] [diff] [review]
Patch v1

     nsCOMPtr<nsIContent> frame = do_QueryInterface(GetFrameElementInternal());
-    if (frame && frame->OwnerDoc()) {
+    if (frame) {

This looks unrelated, what triggered this change here? I think it's probably a correct change, but I'd need to look a bit deeper to verify, unless you already did :)
OwnerDoc() never returns null (since strong-parent-node), so I tend to remove null checks when I spot them. Can drop it from this patch if you prefer
Comment on attachment 604753 [details] [diff] [review]
Patch v1

Good point. Some day I will remember that myself too :)
Attachment #604753 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/9fdfd263167b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.