Closed
Bug 734777
Opened 13 years ago
Closed 12 years ago
"ASSERTION: value should always be stored and non-empty when state set"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files, 1 obsolete file)
###!!! ASSERTION: value should always be stored and non-empty when state set: 'prop && !prop->mLines.empty() && prop->mLines.front()->mFirstChild == prop->mFrames.FirstChild()', file layout/generic/nsBlockFrame.cpp, line 4592
Might be a regression from bug 728908.
|
Reporter | |
Comment 1•13 years ago
|
||
|
Assignee | |
Comment 2•13 years ago
|
||
The assertion is a bit of a false alarm, the code functions correctly.
What happens is nsBlockFrame::PullFrameFrom pulls the only frame from
an overflow line. On line 2659 we remove it from the corresponding
frame list (which becomes empty), then we call RemoveOverflowLines()
on line 2690, triggering the assertion.
Assignee: nobody → matspal
OS: Mac OS X → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•13 years ago
|
||
This is one solution. I don't want to do to much work on a line we're
about to delete anyway, but --mChildCount shouldn't be to expensive.
It's 2.30am here so I'm going to sleep on it before asking for review.
Let me know if you have a better idea.
|
|
Assignee | |
Comment 5•12 years ago
|
||
The attached test doesn't trigger the assertion anymore for some
reason, but layout/generic/crashtests/520340.html does.
Attachment #604813 -
Attachment is obsolete: true
Attachment #696118 -
Flags: review?(roc)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #696118 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Severity: normal → trivial
Flags: in-testsuite+
|
||
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•