734880 - Bottom center area of the relative layout in the tabs tray permits an empty click

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/12) Screenshot

See attached screenshot.

bug 708266 added a Gecko LinkTextView to the relative layout in the tabs tray. With this came an area to the left of it and to the right of the new tab button that permits a tap which simply closes the tabs tray. Is this expected behaviour?

Comment 1

[Aaron Train [:aaronmt]]

What's the expected behaviour here?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

This also affects people without sync setup. You now must hit the plus exactly.

Comment 3

[Madhava Enros [:madhava]]

my $0.02 -- we should make sure that the + button has large enough a touch area. We can't just have it be the whole row now that we have another element at far right. Do we need a visual divider?

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: mockup of touch areas

Touching the middle area should do nothing. (It shouldn't close the menu)

Also, as Madhava mentioned, the touch areas on the icon and text links should be big enough to be easy to touch. Judging by Aaron's screenshot, they look like they should both extend inwards a bit more to increase surface area. 

I can think about what a visual divider might look like, though I'm not sure I would use one to separate an icon from a text link, it might look a little odd. (Not saying no, I'm just not sure yet.) 

For the purposes of this bug, let's just make the touch areas slightly bigger, and disable any actions that are prompted by touching the middle part of the bar.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Could you post specs for the size of the touch areas?

Comment 6

[Ian Barlow (:ibarlow)]

Sriram, the touch areas should fill the height of the row, and extend to the right and left of the icon / text by 18DIP

Comment 7

[Sriram Ramasubramanian [:sriram]]

"+" button extends to row height. But the text is "not a button" and cannot extend that way (I'll try my best). We should also take l10n string size into consideration.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch makes sure we dont quit Tabs-tray when we press anywhere other than "+" and "sync tabs" button in bottom toolbar.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 605955 [details] [diff] [review]
Patch

we didn't really change the size of the button, but "miss clicks" won't close the tabs list.

Comment 10

[Sriram Ramasubramanian [:sriram]]

I am leaving a padding of 20dp on both sides -- which is a bit more than @ibarlow's suggestion of 18dp. Hence I didn't change the value of it. The "+" button is 20 X 20 dp image in a 60 x 50 dp "clickable" area.

Comment 11

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/71dba8336d12

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/71dba8336d12

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fddfa99a3e0a

Comment 14

[Paul Feher]

Verified/fixed on:

Aurora Fennec 13.0a2 (2012-03-27)
Nightly Fennec 14.0a1 (2012-03-27)
Device: Samsung Nexus S
OS: Android 2.3.6