734893 - LinkTextView in the tabs tray can be slow to draw

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

bug 708266 added a LinkTextView to the tabs-tray. On occasion, when opening the tabs tray, I notice that the link is slow to draw (~1/1.5s). In talks on IRC, it's possible that this due to blocking DB access. This bogs down responsiveness of the complete UI showing.

--
Tested via:

Samsung Galaxy Nexus (Android 4.0.2)
Nightly (03/12)
Mozilla/5.0 (Android; Mobile; rv:13.0) Gecko/13.0 Firefox/13.0a1

Comment 2

[Paul [pwd]]

Why does this require a DB call at all?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Paul [sabret00the] from comment #2)
> Why does this require a DB call at all?

So we can hide the link if you don't have any data to see

Comment 4

[Paul [pwd]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Paul [sabret00the] from comment #2)
> > Why does this require a DB call at all?
> 
> So we can hide the link if you don't have any data to see

If a user has sync set up, they likely have data to see. If not there's nothing wrong with a screen saying "No tabs from other devices" or less desirable would be to assume there's tabs available until the query says otherwise. Both would be preferable over the current implementation.

Comment 5

[Aaron Train [:aaronmt]]

"No tabs from other devices", would require the same db check.

Comment 6

[Paul [pwd]]

After the fact, once you've already pulled up the screen.

Comment 7

[Tony Chung [:tchung]]

Is this still happening on today's build for people?  I also noticed this 3 days ago, but today's nightly build seems much more quicker to draw.  (03-15-2012, galaxy nexus)

Comment 8

[Aaron Train [:aaronmt]]

Nominating for poor performance perception in the product.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch sends a simplified query to the database.
Also, the GeckoAsyncTask uses priority to do certain tasks with higher priority.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 606770 [details] [diff] [review]
Patch

Looks ok to me. Asking Brad for a quick review on the GeckoAsyncTask change.

It would be nice to get performance feedback on this patch before it lands. Hopefully Tony or Aaron can test a build on their phones.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 606770 [details] [diff] [review]
Patch

Review of attachment 606770 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAsyncTask.java
@@ +53,2 @@
>      public void execute(final Params... params) {
> +        Runnable r = new Runnable() {

move this Runnable out of the function:

UITaskRunnable implements Runnable {
  public void run() {
    ...
  }
}

public void execute(final Params... params) {

Comment 12

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/837da0646b7d

Comment 13

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/837da0646b7d

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/86d9c18c1460

Comment 15

[Adrian Tamas (:AdrianT)]

Links show instantly on Aurora 15.0a2 2012-06-09 and Nightly 16.0a1 2012-06-10 on the HTC Desire running Android 2.2. Marking the issue as verified.