Note: There are a few cases of duplicates in user autocompletion which are being worked on.

LinkTextView in the tabs tray can be slow to draw

VERIFIED FIXED in Firefox 14

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: sriram)

Tracking

unspecified
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(blocking-fennec1.0 +)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
bug 708266 added a LinkTextView to the tabs-tray. On occasion, when opening the tabs tray, I notice that the link is slow to draw (~1/1.5s). In talks on IRC, it's possible that this due to blocking DB access. This bogs down responsiveness of the complete UI showing.

--
Tested via:

Samsung Galaxy Nexus (Android 4.0.2)
Nightly (03/12)
Mozilla/5.0 (Android; Mobile; rv:13.0) Gecko/13.0 Firefox/13.0a1
(Reporter)

Updated

5 years ago
Duplicate of this bug: 735027

Comment 2

5 years ago
Why does this require a DB call at all?
(In reply to Paul [sabret00the] from comment #2)
> Why does this require a DB call at all?

So we can hide the link if you don't have any data to see

Comment 4

5 years ago
(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Paul [sabret00the] from comment #2)
> > Why does this require a DB call at all?
> 
> So we can hide the link if you don't have any data to see

If a user has sync set up, they likely have data to see. If not there's nothing wrong with a screen saying "No tabs from other devices" or less desirable would be to assume there's tabs available until the query says otherwise. Both would be preferable over the current implementation.
(Reporter)

Comment 5

5 years ago
"No tabs from other devices", would require the same db check.

Comment 6

5 years ago
After the fact, once you've already pulled up the screen.

Comment 7

5 years ago
Is this still happening on today's build for people?  I also noticed this 3 days ago, but today's nightly build seems much more quicker to draw.  (03-15-2012, galaxy nexus)
(Reporter)

Comment 8

5 years ago
Nominating for poor performance perception in the product.

Updated

5 years ago
blocking-fennec1.0: --- → ?
Assignee: nobody → sriram
blocking-fennec1.0: ? → +
(Assignee)

Comment 9

5 years ago
Created attachment 606770 [details] [diff] [review]
Patch

This patch sends a simplified query to the database.
Also, the GeckoAsyncTask uses priority to do certain tasks with higher priority.
Attachment #606770 - Flags: review?(mark.finkle)
Comment on attachment 606770 [details] [diff] [review]
Patch

Looks ok to me. Asking Brad for a quick review on the GeckoAsyncTask change.

It would be nice to get performance feedback on this patch before it lands. Hopefully Tony or Aaron can test a build on their phones.
Attachment #606770 - Flags: review?(mark.finkle)
Attachment #606770 - Flags: review?(blassey.bugs)
Attachment #606770 - Flags: review+
(Reporter)

Updated

5 years ago
Keywords: qawanted
Comment on attachment 606770 [details] [diff] [review]
Patch

Review of attachment 606770 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAsyncTask.java
@@ +53,2 @@
>      public void execute(final Params... params) {
> +        Runnable r = new Runnable() {

move this Runnable out of the function:

UITaskRunnable implements Runnable {
  public void run() {
    ...
  }
}

public void execute(final Params... params) {
Attachment #606770 - Flags: review?(blassey.bugs) → review+
(Reporter)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 12

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/837da0646b7d
https://hg.mozilla.org/mozilla-central/rev/837da0646b7d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/releases/mozilla-aurora/rev/86d9c18c1460
status-firefox13: --- → fixed
status-firefox14: --- → fixed
(Reporter)

Updated

5 years ago
Keywords: qawanted
Links show instantly on Aurora 15.0a2 2012-06-09 and Nightly 16.0a1 2012-06-10 on the HTC Desire running Android 2.2. Marking the issue as verified.
Status: RESOLVED → VERIFIED
status-firefox13: fixed → ---
status-firefox14: fixed → ---
You need to log in before you can comment on or make changes to this bug.