734920 - Add a comment to anim-use-length-02.svg explaining what it's testing

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

anim-use-length-02.svg could really do with a comment explaining that setting width/height to zero disables rendering of a <use>, and that the test is checking that rendering is un-disabled at the end of a <set> animation that has set width/height to zero.

Given that the <use> is referencing a <g>, its really easy to miss/forget that width/height actually _do_ have an affect in the special zero value case. I just spent a good 10 minutes totally misunderstanding what this test is trying to do.

Comment 1

[Robert Longson [:longsonr]]

Actually since bug 1762792, this reftest hasn't tested anything much at all.

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 734920 - Fix anim-use-length-02.svg and explain what it's testing r=dholbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e58c092c984
https://hg.mozilla.org/integration/autoland/rev/44c43103ad61
Fix anim-use-length-02.svg and explain what it's testing r=dholbert

Comment 4

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/44c43103ad61