735058 - [dev][traceback] Error: KeyError: u'sr-latn'

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - 500 error

Steps to reproduce:
1. Goto https://affiliates-dev.allizom.org/en-US/banners/customize/1

Traceback (most recent call last):

 File "/data/www/affiliates-dev.allizom.org/affiliates-app/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/affiliates-dev.allizom.org/affiliates-app/apps/shared/decorators.py", line 11, in decorator
   return view_func(request, *args, **kwargs)

 File "/data/www/affiliates-dev.allizom.org/affiliates-app/apps/banners/views.py", line 38, in customize
   banner_images = BannerImage.objects.customize_values(banner=banner)

 File "/data/www/affiliates-dev.allizom.org/affiliates-app/apps/banners/models.py", line 62, in customize_values
   } for img in self.filter(**kwargs)]

 File "/data/www/affiliates-dev.allizom.org/affiliates-app/vendor/src/django/django/utils/functional.py", line 196, in __wrapper__
   return self.__dispatch[t][funcname](res, *args, **kw)

KeyError: u'sr-latn'

Comment 1

[Osmose [:osmose, :mkelly]]

Fixed in https://github.com/mozilla/affiliates/commit/2ef1587c6b89c05c9ff20e65501a93744a10d786

Comment 2

[Anthony Ricaud (:rik)]

Changing this to next week release since it is a bit short to test and do the right fix.

Comment 3

[Matt Brandt [:mbrandt]]

QA verified on dev - the manual usecase passes. Our automated tests are also passing when run against trunk.